Issue 7075019: Move a bunch of functions from Window onto Widget.

Issue 7075019: Move a bunch of functions from Window onto Widget. (Closed)

Created:
9 years, 7 months ago by Ben Goodger (Google)

Modified:
9 years, 6 months ago

Reviewers:
sky

CC:
chromium-reviews

Base URL:
svn://svn.chromium.org/chrome/trunk/src/

Visibility:
Public.

Description

Move a bunch of functions from Window onto Widget. BUG=72040 TEST=none Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=86914 Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=87029

Patch Set 1 : '' #

Patch Set 2 : '' #

Total comments: 1

Patch Set 3 : '' #

Patch Set 4 : '' #

Created: 9 years, 7 months ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+322 lines, -421 lines)			Patch
M	chrome/browser/chromeos/login/background_view.cc	View	1 2 3	1 chunk	+1 line, -1 line	0 comments	Download
M	chrome/browser/chromeos/login/eula_view.cc	View	1 2 3	1 chunk	+1 line, -1 line	0 comments	Download
M	chrome/browser/chromeos/login/existing_user_controller.cc	View	1 2 3	2 chunks	+2 lines, -2 lines	0 comments	Download
M	chrome/browser/chromeos/network_login_observer.cc	View	1 2 3	1 chunk	+1 line, -1 line	0 comments	Download
M	chrome/browser/chromeos/status/network_menu.cc	View	1 2 3	1 chunk	+1 line, -1 line	0 comments	Download
M	chrome/browser/ui/views/first_run_search_engine_view.cc	View	1 2 3	1 chunk	+1 line, -1 line	0 comments	Download
M	chrome/browser/ui/views/frame/browser_view.cc	View	1 2 3	1 chunk	+1 line, -1 line	0 comments	Download
M	chrome/browser/ui/views/task_manager_view.cc	View	1 2 3	2 chunks	+2 lines, -2 lines	0 comments	Download
M	chrome/browser/ui/webui/options/chromeos/change_picture_options_handler.cc	View	1 2 3	1 chunk	+1 line, -1 line	0 comments	Download
M	chrome/browser/ui/webui/options/chromeos/internet_options_handler.cc	View	1 2 3	1 chunk	+1 line, -1 line	0 comments	Download
M	views/widget/native_widget.h	View	1 2 3	1 chunk	+9 lines, -2 lines	0 comments	Download
M	views/widget/native_widget_gtk.h	View	1 2 3	3 chunks	+15 lines, -2 lines	0 comments	Download
M	views/widget/native_widget_gtk.cc	View	1 2 3	5 chunks	+52 lines, -12 lines	0 comments	Download
M	views/widget/native_widget_views.h	View	1 2 3	1 chunk	+9 lines, -2 lines	0 comments	Download
M	views/widget/native_widget_views.cc	View	1 2 3	1 chunk	+35 lines, -5 lines	0 comments	Download
M	views/widget/native_widget_win.h	View	1 2 3	2 chunks	+12 lines, -2 lines	0 comments	Download
M	views/widget/native_widget_win.cc	View	1 2 3	2 chunks	+46 lines, -9 lines	0 comments	Download
M	views/widget/widget.h	View	1 2 3	3 chunks	+34 lines, -8 lines	0 comments	Download
M	views/widget/widget.cc	View	1 2 3	1 chunk	+32 lines, -4 lines	0 comments	Download
M	views/window/native_window.h	View	1 2 3	1 chunk	+0 lines, -12 lines	0 comments	Download
M	views/window/native_window_gtk.h	View	1 2 3	4 chunks	+5 lines, -20 lines	0 comments	Download
M	views/window/native_window_gtk.cc	View	1 2 3	7 chunks	+17 lines, -71 lines	0 comments	Download
M	views/window/native_window_views.h	View	1 2 3	1 chunk	+0 lines, -12 lines	0 comments	Download
M	views/window/native_window_views.cc	View	1 2 3	3 chunks	+0 lines, -49 lines	0 comments	Download
M	views/window/native_window_win.h	View	1 2 3	2 chunks	+3 lines, -15 lines	0 comments	Download
M	views/window/native_window_win.cc	View	1 2 3	5 chunks	+9 lines, -61 lines	0 comments	Download
M	views/window/window.h	View	1 2 3	4 chunks	+4 lines, -50 lines	0 comments	Download
M	views/window/window.cc	View	1 2 3	4 chunks	+28 lines, -73 lines	0 comments	Download

Messages

Total messages: 2 (0 generated)

Expand Messages | Collapse Messages

sky

9 years, 7 months ago (2011-05-26 21:40:19 UTC) #2

LGTM

http://codereview.chromium.org/7075019/diff/9004/views/widget/native_widget_g...
File views/widget/native_widget_gtk.cc (right):

http://codereview.chromium.org/7075019/diff/9004/views/widget/native_widget_g...
views/widget/native_widget_gtk.cc:1015: static_cast<gdouble>(255));
nit: indent 2 more.

Expand Messages | Collapse Messages