Remove flag to disable ignore autocomplete='off' for password forms.

Remove flag to disable ignore autocomplete='off' for password forms.

This CL removes the plumbing for the flag to disable the ignoring of
autocomplet='off' for password fields. This plumbing was always intended
to be temporary in case something disastrous happened and we needed to
re-enable autocomplete='off' via Finch. The time we set for this has
past, so this CL makes this a permanent change.

BUG=346708
Committed: https://crrev.com/fdfc765d2bd2a6d674bad2fa4f2b064f56701aaa
Cr-Commit-Position: refs/heads/master@{#302707}

[jww, 2014-11-03 22:21:36]

jww@chromium.org changed reviewers:
+ vabr@chromium.org

[jww, 2014-11-03 22:21:57]

vabr@, can you check this out for me? Thanks!

[vabr (Chromium), 2014-11-04 07:59:38]

Hi jww@,

Recalling the last team meeting, where we discussed the possibilities to disable
password manager selectively for enterprise admins -- would none of this code be
useful in case we need to extend the available policies?

Other than that LGTM, so feel free to land if the above paragraph is of no
concern in your opinion.

Cheers,
Vaclav

[jww, 2014-11-04 16:09:10]

On 2014/11/04 07:59:38, vabr (Chromium) wrote:
> Hi jww@,
> 
> Recalling the last team meeting, where we discussed the possibilities to
disable
> password manager selectively for enterprise admins -- would none of this code
be
> useful in case we need to extend the available policies?
> 
> Other than that LGTM, so feel free to land if the above paragraph is of no
> concern in your opinion.
> 
> Cheers,
> Vaclav

I believe what we discussed is enterprise policies for disabling the entire
password manager for certain sites, not re-enabling autocomplete='off'. That
having been said, I'm happy to let this CL marinate for a bit longer; I'm not in
any particular rush to commit this.

[vabr (Chromium), 2014-11-04 20:42:54]

Hi Joel,

I don't think you need to wait with landing the CL.

My recollection matches yours, I just wanted to double-check.

Cheers,
Vaclav

[jww, 2014-11-04 21:44:49]

jww@chromium.org changed reviewers:
+ isherman@chromium.org

[jww, 2014-11-04 21:44:49]

isherman@chromium.org: Please owner review: 
chrome/renderer/autofill/password_autofill_agent_browsertest.cc
components/autofill.gypi

Feel free to drive-by review anything else that catches your eye as well.

[Ilya Sherman, 2014-11-04 22:28:38]

LGTM.  Thanks for the cleanup :)

[Ilya Sherman, 2014-11-04 22:28:51]

The CQ bit was checked by isherman@chromium.org

[commit-bot: I haz the power, 2014-11-04 22:31:34]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/697233002/1

[commit-bot: I haz the power, 2014-11-04 23:36:16]

Committed patchset #1 (id:1)

[commit-bot: I haz the power, 2014-11-04 23:37:52]

Patchset 1 (id:??) landed as
https://crrev.com/fdfc765d2bd2a6d674bad2fa4f2b064f56701aaa
Cr-Commit-Position: refs/heads/master@{#302707}