Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(440)

Unified Diff: components/password_manager/core/browser/password_manager.cc

Issue 697233002: Remove flag to disable ignore autocomplete='off' for password forms. (Closed) Base URL: https://chromium.googlesource.com/chromium/src@master
Patch Set: Created 6 years, 1 month ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « components/password_manager/core/browser/password_manager.h ('k') | no next file » | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: components/password_manager/core/browser/password_manager.cc
diff --git a/components/password_manager/core/browser/password_manager.cc b/components/password_manager/core/browser/password_manager.cc
index c9925e5da705f28bc6d44066b1d5d4d8cba265c4..c545f9f7e942605eef1f6ade1b6d75fa8a216821 100644
--- a/components/password_manager/core/browser/password_manager.cc
+++ b/components/password_manager/core/browser/password_manager.cc
@@ -11,7 +11,6 @@
#include "base/strings/string_util.h"
#include "base/strings/utf_string_conversions.h"
#include "base/threading/platform_thread.h"
-#include "components/autofill/core/common/password_autofill_util.h"
#include "components/password_manager/core/browser/browser_save_password_progress_logger.h"
#include "components/password_manager/core/browser/password_autofill_manager.h"
#include "components/password_manager/core/browser/password_form_manager.h"
@@ -279,15 +278,6 @@ void PasswordManager::ProvisionallySavePassword(const PasswordForm& form) {
return;
}
- // Always save generated passwords, as the user expresses explicit intent for
- // Chrome to manage such passwords. For other passwords, respect the
- // autocomplete attribute if autocomplete='off' is not ignored.
- if (!autofill::ShouldIgnoreAutocompleteOffForPasswordFields() &&
- !manager->HasGeneratedPassword() && !form.password_autocomplete_set) {
- RecordFailure(AUTOCOMPLETE_OFF, form.origin.host(), logger.get());
- return;
- }
-
PasswordForm provisionally_saved_form(form);
provisionally_saved_form.ssl_valid =
form.origin.SchemeIsSecure() &&
@@ -345,9 +335,6 @@ void PasswordManager::RecordFailure(ProvisionalSaveFailure failure,
case INVALID_FORM:
logger->LogMessage(Logger::STRING_INVALID_FORM);
break;
- case AUTOCOMPLETE_OFF:
- logger->LogMessage(Logger::STRING_AUTOCOMPLETE_OFF);
- break;
case SYNC_CREDENTIAL:
logger->LogMessage(Logger::STRING_SYNC_CREDENTIAL);
break;
« no previous file with comments | « components/password_manager/core/browser/password_manager.h ('k') | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698