components/autofill/core/common/save_password_progress_logger.cc - Issue 697233002: Remove flag to disable ignore autocomplete='off' for password forms.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: components/autofill/core/common/save_password_progress_logger.cc

Issue 697233002: Remove flag to disable ignore autocomplete='off' for password forms. (Closed) Base URL: https://chromium.googlesource.com/chromium/src@master

Patch Set: Created 6 years, 1 month ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « components/autofill/core/common/save_password_progress_logger.h ('k') | components/password_manager/core/browser/password_manager.h » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: components/autofill/core/common/save_password_progress_logger.cc

diff --git a/components/autofill/core/common/save_password_progress_logger.cc b/components/autofill/core/common/save_password_progress_logger.cc

index 034760b7ccc963ba14f72727a9fd75c980c5ba74..91af1a09786773d8c37da8b8eddd31752b63811a 100644

--- a/components/autofill/core/common/save_password_progress_logger.cc

+++ b/components/autofill/core/common/save_password_progress_logger.cc

@@ -133,8 +133,6 @@ std::string GetStringFromID(SavePasswordProgressLogger::StringID id) {

return "Form blacklisted.";

case SavePasswordProgressLogger::STRING_INVALID_FORM:

return "Invalid form.";

- case SavePasswordProgressLogger::STRING_AUTOCOMPLETE_OFF:

- return "Autocomplete=off.";

case SavePasswordProgressLogger::STRING_SYNC_CREDENTIAL:

return "Credential is used for syncing passwords.";

case SavePasswordProgressLogger::STRING_PROVISIONALLY_SAVED_FORM: