Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(18)

Issue 696033002: Cleanup: Better constify some strings in net/. (Closed)

Created:
6 years, 1 month ago by Lei Zhang
Modified:
5 years, 11 months ago
Reviewers:
eroman, abarth-chromium
CC:
cbentzel+watch_chromium.org, chromium-apps-reviews_chromium.org, chromium-reviews, erikwright (departed), extensions-reviews_chromium.org, gavinp+disk_chromium.org, jshin+watch_chromium.org, Paweł Hajdan Jr.
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Cleanup: Better constify some strings in net/. Committed: https://crrev.com/9d3bb0c75ddbeafd53f5ad32813b0fe70b7e0779 Cr-Commit-Position: refs/heads/master@{#312985}

Patch Set 1 #

Patch Set 2 : #

Patch Set 3 : rebase #

Patch Set 4 : rebase #

Patch Set 5 : static #

Unified diffs Side-by-side diffs Delta from patch set Stats (+318 lines, -311 lines) Patch
M net/base/address_list_unittest.cc View 1 chunk +1 line, -1 line 0 comments Download
M net/base/mime_sniffer.cc View 1 2 3 4 chunks +6 lines, -6 lines 0 comments Download
M net/base/mime_util.cc View 1 2 3 5 chunks +7 lines, -7 lines 0 comments Download
M net/base/mime_util_unittest.cc View 1 2 3 5 chunks +13 lines, -12 lines 0 comments Download
M net/base/net_string_util_icu_alternatives_android.cc View 1 chunk +1 line, -1 line 0 comments Download
M net/base/net_util_icu.cc View 1 chunk +2 lines, -2 lines 0 comments Download
M net/base/net_util_icu_unittest.cc View 5 chunks +9 lines, -9 lines 0 comments Download
M net/base/net_util_unittest.cc View 1 2 3 13 chunks +19 lines, -19 lines 0 comments Download
M net/base/network_change_notifier.cc View 1 2 3 1 chunk +1 line, -1 line 0 comments Download
M net/base/registry_controlled_domains/registry_controlled_domain_unittest.cc View 4 chunks +22 lines, -22 lines 0 comments Download
M net/cert/x509_cert_types_win.cc View 1 chunk +1 line, -1 line 0 comments Download
M net/cookies/cookie_constants_unittest.cc View 1 chunk +2 lines, -1 line 0 comments Download
M net/cookies/cookie_monster_perftest.cc View 3 chunks +3 lines, -3 lines 0 comments Download
M net/cookies/cookie_monster_unittest.cc View 2 chunks +6 lines, -6 lines 0 comments Download
M net/cookies/cookie_util.cc View 2 chunks +4 lines, -3 lines 0 comments Download
M net/cookies/parsed_cookie_unittest.cc View 2 chunks +9 lines, -9 lines 0 comments Download
M net/disk_cache/backend_unittest.cc View 1 2 3 3 chunks +4 lines, -4 lines 0 comments Download
M net/disk_cache/blockfile/backend_impl.cc View 1 2 3 1 chunk +1 line, -1 line 0 comments Download
M net/disk_cache/blockfile/backend_impl_v3.cc View 1 2 3 1 chunk +2 lines, -1 line 0 comments Download
M net/disk_cache/blockfile/backend_worker_v3.cc View 1 chunk +1 line, -1 line 0 comments Download
M net/disk_cache/blockfile/block_files.cc View 1 2 3 1 chunk +1 line, -1 line 0 comments Download
M net/disk_cache/blockfile/stats.cc View 1 2 3 1 chunk +1 line, -1 line 0 comments Download
M net/dns/address_sorter_posix_unittest.cc View 12 chunks +20 lines, -20 lines 0 comments Download
M net/dns/dns_config_service_posix_unittest.cc View 2 chunks +2 lines, -2 lines 0 comments Download
M net/ftp/ftp_directory_listing_parser.cc View 1 chunk +1 line, -1 line 0 comments Download
M net/ftp/ftp_directory_listing_parser_ls_unittest.cc View 2 chunks +2 lines, -2 lines 0 comments Download
M net/ftp/ftp_directory_listing_parser_netware_unittest.cc View 1 chunk +1 line, -1 line 0 comments Download
M net/ftp/ftp_directory_listing_parser_os2_unittest.cc View 2 chunks +2 lines, -2 lines 0 comments Download
M net/ftp/ftp_directory_listing_parser_unittest.cc View 1 chunk +1 line, -1 line 0 comments Download
M net/ftp/ftp_directory_listing_parser_vms.cc View 1 chunk +1 line, -1 line 0 comments Download
M net/ftp/ftp_directory_listing_parser_vms_unittest.cc View 2 chunks +2 lines, -2 lines 0 comments Download
M net/ftp/ftp_directory_listing_parser_windows_unittest.cc View 2 chunks +2 lines, -2 lines 0 comments Download
M net/ftp/ftp_network_transaction_unittest.cc View 1 2 3 4 1 chunk +3 lines, -2 lines 0 comments Download
M net/http/http_auth_cache_unittest.cc View 1 chunk +5 lines, -5 lines 0 comments Download
M net/http/http_cache_unittest.cc View 1 2 3 14 chunks +15 lines, -15 lines 0 comments Download
M net/http/http_chunked_decoder_unittest.cc View 26 chunks +31 lines, -30 lines 0 comments Download
M net/http/http_network_transaction_unittest.cc View 1 2 3 7 chunks +8 lines, -8 lines 0 comments Download
M net/http/http_response_headers.cc View 1 2 3 1 chunk +3 lines, -2 lines 0 comments Download
M net/http/http_util.cc View 1 2 1 chunk +1 line, -1 line 0 comments Download
M net/http/http_util_unittest.cc View 1 2 10 chunks +18 lines, -18 lines 0 comments Download
M net/http/http_vary_data_unittest.cc View 1 chunk +1 line, -1 line 0 comments Download
M net/http/transport_security_state_unittest.cc View 1 2 3 2 chunks +2 lines, -2 lines 0 comments Download
M net/http/url_security_manager_unittest.cc View 1 chunk +2 lines, -2 lines 0 comments Download
M net/proxy/dhcp_proxy_script_adapter_fetcher_win_unittest.cc View 1 2 3 1 chunk +1 line, -1 line 0 comments Download
M net/proxy/proxy_config_source.cc View 1 2 3 1 chunk +1 line, -1 line 0 comments Download
M net/proxy/proxy_server_unittest.cc View 6 chunks +11 lines, -11 lines 0 comments Download
M net/quic/crypto/crypto_server_test.cc View 1 2 3 3 chunks +3 lines, -3 lines 0 comments Download
M net/quic/quic_fec_group_test.cc View 1 chunk +1 line, -1 line 0 comments Download
M net/server/http_server_unittest.cc View 3 chunks +3 lines, -3 lines 0 comments Download
M net/socket/ssl_client_socket_unittest.cc View 1 2 3 1 chunk +3 lines, -3 lines 0 comments Download
M net/socket/ssl_server_socket_unittest.cc View 1 2 2 chunks +3 lines, -3 lines 0 comments Download
M net/spdy/spdy_session.cc View 1 2 3 1 chunk +2 lines, -2 lines 0 comments Download
M net/tools/crash_cache/crash_cache.cc View 1 2 3 1 chunk +2 lines, -2 lines 0 comments Download
M net/tools/quic/end_to_end_test.cc View 1 2 3 1 chunk +2 lines, -2 lines 0 comments Download
M net/tools/quic/spdy_utils.cc View 1 2 3 1 chunk +8 lines, -8 lines 0 comments Download
M net/tools/quic/test_tools/http_message.cc View 1 chunk +5 lines, -5 lines 0 comments Download
M net/udp/udp_socket_unittest.cc View 1 2 3 1 chunk +1 line, -1 line 0 comments Download
M net/url_request/sdch_dictionary_fetcher_unittest.cc View 1 2 3 1 chunk +2 lines, -2 lines 0 comments Download
M net/websockets/websocket_extension_parser_test.cc View 1 chunk +1 line, -1 line 0 comments Download
M net/websockets/websocket_handshake_constants.h View 2 chunks +15 lines, -15 lines 0 comments Download
M net/websockets/websocket_handshake_constants.cc View 1 chunk +15 lines, -15 lines 0 comments Download

Messages

Total messages: 20 (7 generated)
Lei Zhang
constify all the things! For a Linux release build of net_unittests, the effects on various ...
6 years, 1 month ago (2014-11-01 02:24:13 UTC) #2
eroman
lgtm
6 years, 1 month ago (2014-11-04 20:35:31 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/696033002/20001
6 years, 1 month ago (2014-11-04 21:23:51 UTC) #5
commit-bot: I haz the power
Try jobs failed on following builders: chromium_presubmit on tryserver.chromium.linux (http://build.chromium.org/p/tryserver.chromium.linux/builders/chromium_presubmit/builds/22106)
6 years, 1 month ago (2014-11-04 21:32:58 UTC) #7
Lei Zhang
abarth: rubber stamp please
6 years, 1 month ago (2014-11-04 21:57:59 UTC) #9
mmenke
Lei Zhang: Are you still planning on landing this CL? Can just TBR abarth.
5 years, 11 months ago (2015-01-20 20:06:10 UTC) #10
Lei Zhang
On 2015/01/20 20:06:10, mmenke wrote: > Lei Zhang: Are you still planning on landing this ...
5 years, 11 months ago (2015-01-20 22:11:10 UTC) #11
abarth-chromium
mime_sniffer.cc LGTM
5 years, 11 months ago (2015-01-21 00:58:12 UTC) #12
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/696033002/60001
5 years, 11 months ago (2015-01-21 22:05:48 UTC) #14
commit-bot: I haz the power
Try jobs failed on following builders: android_dbg_tests_recipe on tryserver.chromium.linux (http://build.chromium.org/p/tryserver.chromium.linux/builders/android_dbg_tests_recipe/builds/47254)
5 years, 11 months ago (2015-01-21 23:41:07 UTC) #16
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/696033002/80001
5 years, 11 months ago (2015-01-24 00:46:11 UTC) #18
commit-bot: I haz the power
Committed patchset #5 (id:80001)
5 years, 11 months ago (2015-01-24 00:50:22 UTC) #19
commit-bot: I haz the power
5 years, 11 months ago (2015-01-24 00:51:34 UTC) #20
Message was sent while issue was closed.
Patchset 5 (id:??) landed as
https://crrev.com/9d3bb0c75ddbeafd53f5ad32813b0fe70b7e0779
Cr-Commit-Position: refs/heads/master@{#312985}

Powered by Google App Engine
This is Rietveld 408576698