Cleanup: Better constify some strings in net/.

net/cookies/parsed_cookie_unittest.cc

 // Copyright (c) 2012 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #include <string>
 
 #include "net/cookies/cookie_constants.h"
 #include "net/cookies/parsed_cookie.h"
 #include "testing/gtest/include/gtest/gtest.h"
 
@@ skipping 20 matching lines @@
   EXPECT_FALSE(pc5.IsValid());
   ParsedCookie pc6("; path=/; secure;");
   EXPECT_FALSE(pc6.IsValid());
 }
 
 TEST(ParsedCookieTest, TestQuoted) {
   // These are some quoting cases which the major browsers all
   // handle differently.  I've tested Internet Explorer 6, Opera 9.6,
   // Firefox 3, and Safari Windows 3.2.1.  We originally tried to match
   // Firefox closely, however we now match Internet Explorer and Safari.
-  const char* values[] = {
+  const char* const values[] = {
     // Trailing whitespace after a quoted value.  The whitespace after
     // the quote is stripped in all browsers.
     "\"zzz \"  ",              "\"zzz \"",
     // Handling a quoted value with a ';', like FOO="zz;pp"  ;
     // IE and Safari: "zz;
     // Firefox and Opera: "zz;pp"
     "\"zz;pp\" ;",             "\"zz",
     // Handling a value with multiple quoted parts, like FOO="zzz "   "ppp" ;
     // IE and Safari: "zzz "   "ppp";
     // Firefox: "zzz ";
@@ skipping 412 matching lines @@
   EXPECT_FALSE(pc8.IsValid());
   EXPECT_FALSE(pc9.IsValid());
   EXPECT_FALSE(pc10.IsValid());
   EXPECT_FALSE(pc11.IsValid());
   EXPECT_FALSE(pc12.IsValid());
 }
 
 TEST(ParsedCookieTest, ValidNonAlphanumericChars) {
   // Note that some of these words are pasted backwords thanks to poor vim bidi
   // support. This should not affect the tests, however.
-  const char* pc1_literal = "name=العربية";
-  const char* pc2_literal = "name=普通話";
-  const char* pc3_literal = "name=ภาษาไทย";
-  const char* pc4_literal = "name=עִבְרִית";
-  const char* pc5_literal = "العربية=value";
-  const char* pc6_literal = "普通話=value";
-  const char* pc7_literal = "ภาษาไทย=value";
-  const char* pc8_literal = "עִבְרִית=value";
+  const char pc1_literal[] = "name=العربية";
+  const char pc2_literal[] = "name=普通話";
+  const char pc3_literal[] = "name=ภาษาไทย";
+  const char pc4_literal[] = "name=עִבְרִית";
+  const char pc5_literal[] = "العربية=value";
+  const char pc6_literal[] = "普通話=value";
+  const char pc7_literal[] = "ภาษาไทย=value";
+  const char pc8_literal[] = "עִבְרִית=value";
   ParsedCookie pc1(pc1_literal);
   ParsedCookie pc2(pc2_literal);
   ParsedCookie pc3(pc3_literal);
   ParsedCookie pc4(pc4_literal);
   ParsedCookie pc5(pc5_literal);
   ParsedCookie pc6(pc6_literal);
   ParsedCookie pc7(pc7_literal);
   ParsedCookie pc8(pc8_literal);
 
   EXPECT_TRUE(pc1.IsValid());
   EXPECT_EQ(pc1_literal, pc1.ToCookieLine());
   EXPECT_TRUE(pc2.IsValid());
   EXPECT_EQ(pc2_literal, pc2.ToCookieLine());
   EXPECT_TRUE(pc3.IsValid());
   EXPECT_EQ(pc3_literal, pc3.ToCookieLine());
   EXPECT_TRUE(pc4.IsValid());
   EXPECT_EQ(pc4_literal, pc4.ToCookieLine());
   EXPECT_TRUE(pc5.IsValid());
   EXPECT_EQ(pc5_literal, pc5.ToCookieLine());
   EXPECT_TRUE(pc6.IsValid());
   EXPECT_EQ(pc6_literal, pc6.ToCookieLine());
   EXPECT_TRUE(pc7.IsValid());
   EXPECT_EQ(pc7_literal, pc7.ToCookieLine());
   EXPECT_TRUE(pc8.IsValid());
   EXPECT_EQ(pc8_literal, pc8.ToCookieLine());
 }
 
 }