net/cookies/cookie_constants_unittest.cc - Issue 696033002: Cleanup: Better constify some strings in net/.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: net/cookies/cookie_constants_unittest.cc

Issue 696033002: Cleanup: Better constify some strings in net/. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: static Created 5 years, 11 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: net/cookies/cookie_constants_unittest.cc

diff --git a/net/cookies/cookie_constants_unittest.cc b/net/cookies/cookie_constants_unittest.cc

index f14f11e12793f5f57cc89e20523bc1a1f398f295..87fa1c1b10703a1a9aa7e9947055bfd53b25b75a 100644

--- a/net/cookies/cookie_constants_unittest.cc

+++ b/net/cookies/cookie_constants_unittest.cc

@@ -31,7 +31,8 @@ TEST(CookieConstantsTest, TestCookiePriority) {

EXPECT_LT(COOKIE_PRIORITY_MEDIUM, COOKIE_PRIORITY_HIGH);

// Unrecognized tokens are interpreted as COOKIE_PRIORITY_DEFAULT.

- const char* bad_tokens[] = {"", "lo", "lowerest", "high ", " high", "0"};

+ const char* const bad_tokens[] = {

+ "", "lo", "lowerest", "high ", " high", "0"};

for (size_t i = 0; i < arraysize(bad_tokens); ++i) {

EXPECT_EQ(COOKIE_PRIORITY_DEFAULT, StringToCookiePriority(bad_tokens[i]));

}

« no previous file with comments | « net/cert/x509_cert_types_win.cc ('k') | net/cookies/cookie_monster_perftest.cc » ('j') | no next file with comments »