Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(598)

Issue 695533003: Increase delay when after eventually consistent operations in datastore/storage (Closed)

Created:
6 years, 1 month ago by kustermann
Modified:
6 years, 1 month ago
Reviewers:
Søren Gjesse
CC:
reviews_dartlang.org
Base URL:
git@github.com:dart-lang/gcloud.git@master
Visibility:
Public.

Description

Increase delay when after eventually consistent operations in datastore/storage Bucket deletion as well as datastore queries are relying on eventually consistent actions being propagated. This CL increases timeouts. Furthermore: Disable storage_test on browsers, since it uses dart:io transitively. BUG= R=sgjesse@google.com Committed: https://github.com/dart-lang/gcloud/commit/4327e9c32ccb51aa513fd6fd643c194e298049de

Patch Set 1 #

Total comments: 2

Patch Set 2 : #

Unified diffs Side-by-side diffs Delta from patch set Stats (+29 lines, -17 lines) Patch
M .status View 1 chunk +4 lines, -0 lines 0 comments Download
M test/common_e2e.dart View 1 1 chunk +20 lines, -0 lines 0 comments Download
M test/datastore/e2e/datastore_test_impl.dart View 1 chunk +0 lines, -8 lines 0 comments Download
M test/db/e2e/db_test_impl.dart View 1 chunk +0 lines, -8 lines 0 comments Download
M test/storage/e2e_test.dart View 1 chunk +5 lines, -1 line 0 comments Download

Messages

Total messages: 5 (1 generated)
kustermann
6 years, 1 month ago (2014-11-03 14:03:33 UTC) #2
Søren Gjesse
LGTM, thanks https://codereview.chromium.org/695533003/diff/1/test/common_e2e.dart File test/common_e2e.dart (right): https://codereview.chromium.org/695533003/diff/1/test/common_e2e.dart#newcode44 test/common_e2e.dart:44: // So this can make tests flakky. ...
6 years, 1 month ago (2014-11-03 14:06:48 UTC) #3
kustermann
https://codereview.chromium.org/695533003/diff/1/test/common_e2e.dart File test/common_e2e.dart (right): https://codereview.chromium.org/695533003/diff/1/test/common_e2e.dart#newcode44 test/common_e2e.dart:44: // So this can make tests flakky. The following ...
6 years, 1 month ago (2014-11-03 14:07:48 UTC) #4
kustermann
6 years, 1 month ago (2014-11-03 14:09:39 UTC) #5
Message was sent while issue was closed.
Committed patchset #2 (id:20001) manually as
4327e9c32ccb51aa513fd6fd643c194e298049de (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698