Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(639)

Unified Diff: test/storage/e2e_test.dart

Issue 695533003: Increase delay when after eventually consistent operations in datastore/storage (Closed) Base URL: git@github.com:dart-lang/gcloud.git@master
Patch Set: Created 6 years, 1 month ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « test/db/e2e/db_test_impl.dart ('k') | no next file » | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: test/storage/e2e_test.dart
diff --git a/test/storage/e2e_test.dart b/test/storage/e2e_test.dart
index f6c52ecf2eea0ecb2c89191e182fb4d7e635a8a0..fabbf48dff7b3d2b7f77c4ec33f45dd7f28f1d61 100644
--- a/test/storage/e2e_test.dart
+++ b/test/storage/e2e_test.dart
@@ -260,7 +260,11 @@ main() {
return runE2EUnittest(() {
runTests(storage, storage.bucket(testBucket));
}).whenComplete(() {
- storage.deleteBucket(testBucket);
+ // Deleting a bucket relies on eventually consistent behaviour, hence
+ // the delay in attempt to prevent test flakiness.
+ return new Future.delayed(STORAGE_LIST_DELAY, () {
+ return storage.deleteBucket(testBucket);
+ });
});
});
});
« no previous file with comments | « test/db/e2e/db_test_impl.dart ('k') | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698