Increase delay when after eventually consistent operations in datastore/storage

test/common_e2e.dart

 // Copyright (c) 2014, the Dart project authors.  Please see the AUTHORS file
 // for details. All rights reserved. Use of this source code is governed by a
 // BSD-style license that can be found in the LICENSE file.
 
 library gcloud.test.common_e2e;
 
 import 'dart:async';
 import 'dart:io';
 
 import 'package:unittest/unittest.dart';
 import 'package:googleapis_auth/auth_io.dart' as auth;
 import 'package:http/http.dart' as http;
 
 import 'common.dart';
 
 const PROJECT = 'test-project';
 
 // Enviroment variables for specifying the cloud project to use and the
 // location of the service account key for that project.
 const String PROJECT_ENV = 'GCLOUD_E2E_TEST_PROJECT';
 const String SERVICE_KEY_LOCATION_ENV = 'GCLOUD_E2E_TEST_KEY';
 
 // Default project and service key location used when running on the package
 // bot.
 const String DEFAULT_PROJECT = 'dart-gcloud-e2e';
 const String DEFAULT_KEY_LOCATION =
     'gs://dart-archive-internal/keys/dart-gcloud-e2e.json';
 
+// Used for db/datastore e2e tests:
+//
+// Non-ancestor queries (i.e. queries not lookups) result in index scans.
+// The index tables are updated in a "eventually consistent" way.
+//
+// So this can make tests flaky, if the index updates take longer than the
+// following constant.
+const INDEX_UPDATE_DELAY = const Duration(seconds: 20);
+
+// Used for storage e2e tests:
+//
+// List operations on buckets are eventually consistent. Bucket deletion is
+// also dependent on list operations to ensure the bucket is empty before
+// deletion.
+//
+// So this can make tests flakky. The following delay is introduced as an

[Søren Gjesse, 2014/11/03 14:06:48]

flakky -> flaky

[kustermann, 2014/11/03 14:07:48]

Done.

+// attempt to account for that.
+const STORAGE_LIST_DELAY = const Duration(seconds: 5);
+
+
 bool onBot() {
   // When running on the package-bot the current user is chrome-bot.
   var envName;
   if (Platform.isWindows) {
     envName = 'USERNAME';
   } else {
     envName = 'USER';
   }
   return Platform.environment[envName] == 'chrome-bot';
 }
@@ skipping 61 matching lines @@
 
   Future get done => _completer.future;
 
   onDone(success) {
     new Future.sync(() {
       super.onDone(success);
     }).then((_) => _completer.complete(_))
     .catchError((error, stack) => _completer.completeError(error, stack));
   }
 }