Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(112)

Unified Diff: mojo/services/surfaces/surfaces_impl.cc

Issue 695183003: Bring skydebugger closer to clean-shutdown (Closed) Base URL: git@github.com:domokit/mojo.git@master
Patch Set: Fix build and remove outdated comment Created 6 years, 1 month ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: mojo/services/surfaces/surfaces_impl.cc
diff --git a/mojo/services/surfaces/surfaces_impl.cc b/mojo/services/surfaces/surfaces_impl.cc
index 95ff5c16800864c7aef3df74467bd3842e925268..13956a5dd8863b762de35a9de445433afdcce416 100644
--- a/mojo/services/surfaces/surfaces_impl.cc
+++ b/mojo/services/surfaces/surfaces_impl.cc
@@ -25,6 +25,9 @@ SurfacesImpl::SurfacesImpl(cc::SurfaceManager* manager,
}
SurfacesImpl::~SurfacesImpl() {
+ // Destory any outstanding surfaces when the connection goes down for any
jamesr 2014/11/05 19:02:24 s/Destory/Destroy/
+ // reason to avoid ~SurfaceFactory() logging about us failing to do so.
jamesr 2014/11/05 19:02:24 this comment is misleading. we aren't destroying t
+ factory_.DestroyAll();
}
void SurfacesImpl::CreateSurface(SurfaceIdPtr id, mojo::SizePtr size) {
« no previous file with comments | « no previous file | mojo/services/view_manager/display_manager.cc » ('j') | mojo/services/window_manager/window_manager_app.cc » ('J')

Powered by Google App Engine
This is Rietveld 408576698