mojo/services/view_manager/display_manager.cc - Issue 695183003: Bring skydebugger closer to clean-shutdown

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: mojo/services/view_manager/display_manager.cc

Issue 695183003: Bring skydebugger closer to clean-shutdown (Closed) Base URL: git@github.com:domokit/mojo.git@master

Patch Set: Fix build and remove outdated comment Created 6 years, 1 month ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: mojo/services/view_manager/display_manager.cc

diff --git a/mojo/services/view_manager/display_manager.cc b/mojo/services/view_manager/display_manager.cc

index 6106eff4e61b31b4453cce4f8f645f578cbe1536..f13eafad71c69c735fe63fcdf4a61911a6d6d7b2 100644

--- a/mojo/services/view_manager/display_manager.cc

+++ b/mojo/services/view_manager/display_manager.cc

@@ -156,6 +156,8 @@ void DisplayManager::Draw() {

}

void DisplayManager::OnDestroyed() {

+ // This is called when the native_viewport is torn down before

+ // ~DisplayManager may be called.

native_viewport_closed_callback_.Run();

}