Bring skydebugger closer to clean-shutdown

mojo/services/surfaces/surfaces_impl.cc

 // Copyright 2014 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #include "mojo/services/surfaces/surfaces_impl.h"
 
 #include "cc/output/compositor_frame.h"
 #include "cc/resources/returned_resource.h"
 #include "cc/surfaces/display.h"
 #include "cc/surfaces/surface_id_allocator.h"
 #include "mojo/cc/context_provider_mojo.h"
 #include "mojo/cc/direct_output_surface.h"
 #include "mojo/converters/geometry/geometry_type_converters.h"
 #include "mojo/converters/surfaces/surfaces_type_converters.h"
 
 namespace mojo {
 
 SurfacesImpl::SurfacesImpl(cc::SurfaceManager* manager,
                            uint32_t id_namespace,
                            Client* client)
     : manager_(manager),
       factory_(manager, this),
       id_namespace_(id_namespace),
       client_(client) {
 }
 
 SurfacesImpl::~SurfacesImpl() {
+  // Destory any outstanding surfaces when the connection goes down for any

[jamesr, 2014/11/05 19:02:24]

s/Destory/Destroy/

+  // reason to avoid ~SurfaceFactory() logging about us failing to do so.

[jamesr, 2014/11/05 19:02:24]

this comment is misleading. we aren't destroying to avoid a log message, we're
destroying because when the connection is gone all surfaces we might want to
manage should be destroyed.

we might need to refine this in the future

+  factory_.DestroyAll();
 }
 
 void SurfacesImpl::CreateSurface(SurfaceIdPtr id, mojo::SizePtr size) {
   cc::SurfaceId cc_id = id.To<cc::SurfaceId>();
   if (cc::SurfaceIdAllocator::NamespaceForId(cc_id) != id_namespace_) {
     // Bad message, do something bad to the caller?
     NOTREACHED();
     return;
   }
   factory_.Create(id.To<cc::SurfaceId>(), size.To<gfx::Size>());
@@ skipping 68 matching lines @@
                                          base::TimeDelta interval) {
 }
 
 void SurfacesImpl::OutputSurfaceLost() {
 }
 
 void SurfacesImpl::SetMemoryPolicy(const cc::ManagedMemoryPolicy& policy) {
 }
 
 }  // namespace mojo