Update compiler to pick up new externs.

Update compiler to pick up new externs.

R=tbreisacher@chromium.org
BUG=none
TEST=http://build.chromium.org/p/chromium.fyi/builders/Closure%20Compilation%20Linux/

Committed: https://chromium.googlesource.com/chromium/src/+/04f14479784c524508837a47ed17ff465f3e9950

[Dan Beam, 2014-10-31 21:13:01]

Patchset #1 (id:1) has been deleted

[Dan Beam, 2014-10-31 21:13:53]

The CQ bit was checked by dbeam@chromium.org

[commit-bot: I haz the power, 2014-10-31 21:15:41]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/695013002/20001

[Tyler Breisacher (Chromium), 2014-10-31 21:19:28]

tbreisacher@chromium.org changed reviewers:
+ tbreisacher@chromium.org

[Tyler Breisacher (Chromium), 2014-10-31 21:19:28]

We fixed this in
https://github.com/google/closure-compiler/commit/00b4ada6d49f53899ac0ef04b1d...
so if you upgrade to the latest compiler release, I don't think you'll need this
suppression.

[Dan Beam, 2014-10-31 21:26:31]

The CQ bit was unchecked by dbeam@chromium.org

[Dan Beam, 2014-10-31 22:17:47]

On 2014/10/31 21:19:28, Tyler Breisacher (Chromium) wrote:
> We fixed this in
>
https://github.com/google/closure-compiler/commit/00b4ada6d49f53899ac0ef04b1d...
> so if you upgrade to the latest compiler release, I don't think you'll need
this
> suppression.

Done.

[Dan Beam, 2014-10-31 22:18:12]

dbeam@chromium.org changed reviewers:
- arv@chromium.org

[Dan Beam, 2014-10-31 22:19:30]

-arv@, +tbreisacher@

look down, look back...

this cl is now about updating compiler.jar

https://codereview.chromium.org/695013002/diff/40001/third_party/closure_comp...
File
third_party/closure_compiler/runner/test/com/google/javascript/jscomp/ChromePassTest.java
(left):

https://codereview.chromium.org/695013002/diff/40001/third_party/closure_comp...
third_party/closure_compiler/runner/test/com/google/javascript/jscomp/ChromePassTest.java:210:
public void testCrDefineDoesNothingWithExportedNotAName() throws Exception {
duplicated

[Tyler Breisacher (Chromium), 2014-10-31 22:24:03]

lgtm

https://codereview.chromium.org/695013002/diff/40001/ui/webui/resources/js/cr...
File ui/webui/resources/js/cr/ui/focus_row.js (right):

https://codereview.chromium.org/695013002/diff/40001/ui/webui/resources/js/cr...
ui/webui/resources/js/cr/ui/focus_row.js:147: if
(this.boundary_.contains(assertInstanceof(e.target, Node)))
That's kinda ugly :( Is it because the target is typed as Node|null instead of
just Node?

[Dan Beam, 2014-10-31 23:27:32]

https://codereview.chromium.org/695013002/diff/40001/ui/webui/resources/js/cr...
File ui/webui/resources/js/cr/ui/focus_row.js (right):

https://codereview.chromium.org/695013002/diff/40001/ui/webui/resources/js/cr...
ui/webui/resources/js/cr/ui/focus_row.js:147: if
(this.boundary_.contains(assertInstanceof(e.target, Node)))
On 2014/10/31 22:24:03, Tyler Breisacher (Chromium) wrote:
> That's kinda ugly :( Is it because the target is typed as Node|null instead of
> just Node?

e.target is EventTarget, .contains() accepts Node (more specialized)

[commit-bot: I haz the power, 2014-11-03 18:55:00]

Patchset 2 (id:??) landed as
https://crrev.com/04f14479784c524508837a47ed17ff465f3e9950
Cr-Commit-Position: refs/heads/master@{#302455}

[Dan Beam, 2014-11-03 18:55:01]

Committed patchset #2 (id:40001) manually as
04f14479784c524508837a47ed17ff465f3e9950 (presubmit successful).