third_party/closure_compiler/runner/test/com/google/javascript/jscomp/ChromePassTest.java - Issue 695013002: Update compiler to pick up new externs.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: third_party/closure_compiler/runner/test/com/google/javascript/jscomp/ChromePassTest.java

Issue 695013002: Update compiler to pick up new externs. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: asdf Created 6 years, 2 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « third_party/closure_compiler/runner/runner.jar ('k') | ui/webui/resources/js/cr/ui/focus_row.js » ('j') | ui/webui/resources/js/cr/ui/focus_row.js » ('J')
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: third_party/closure_compiler/runner/test/com/google/javascript/jscomp/ChromePassTest.java

diff --git a/third_party/closure_compiler/runner/test/com/google/javascript/jscomp/ChromePassTest.java b/third_party/closure_compiler/runner/test/com/google/javascript/jscomp/ChromePassTest.java

index 830b9ba414499ec45fc260a6ab610876c841c568..df1d1479631ce73497ac6d2afaeac825d6e79453 100644

--- a/third_party/closure_compiler/runner/test/com/google/javascript/jscomp/ChromePassTest.java

+++ b/third_party/closure_compiler/runner/test/com/google/javascript/jscomp/ChromePassTest.java

@@ -207,21 +207,6 @@ public class ChromePassTest extends CompilerTestCase {

"});\n");

}

- public void testCrDefineDoesNothingWithExportedNotAName() throws Exception {

Dan Beam 2014/10/31 22:19:30 duplicated

- test(

- "cr.define('namespace', function() {\n" +

- " return {\n" +

- " a: 42\n" +

- " };\n" +

- "});\n",

- "var namespace = namespace || {};\n" +

- "cr.define('namespace', function() {\n" +

- " return {\n" +

- " a: 42\n" +

- " };\n" +

- "});\n");

- }

public void testCrDefineChangesReferenceToExportedFunction() throws Exception {

test(

"cr.define('namespace', function() {\n" +

« no previous file with comments | « third_party/closure_compiler/runner/runner.jar ('k') | ui/webui/resources/js/cr/ui/focus_row.js » ('j') | ui/webui/resources/js/cr/ui/focus_row.js » ('J')