ui/webui/resources/js/cr/ui/focus_row.js - Issue 695013002: Update compiler to pick up new externs.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: ui/webui/resources/js/cr/ui/focus_row.js

Issue 695013002: Update compiler to pick up new externs. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: asdf Created 6 years, 2 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: ui/webui/resources/js/cr/ui/focus_row.js

diff --git a/ui/webui/resources/js/cr/ui/focus_row.js b/ui/webui/resources/js/cr/ui/focus_row.js

index d259d0aaea6261e5843451a149fa02df1e9dff32..b989f538f80d338d267082661389e03217fed0cd 100644

--- a/ui/webui/resources/js/cr/ui/focus_row.js

+++ b/ui/webui/resources/js/cr/ui/focus_row.js

@@ -144,7 +144,7 @@ cr.define('cr.ui', function() {

* @private

onFocusin_: function(e) {

- if (this.boundary_.contains(e.target))

+ if (this.boundary_.contains(assertInstanceof(e.target, Node)))

Tyler Breisacher (Chromium) 2014/10/31 22:24:03 That's kinda ugly :( Is it because the target is t

Dan Beam 2014/10/31 23:27:32 e.target is EventTarget, .contains() accepts Node

this.activeIndex = this.items.indexOf(e.target);