Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(29)

Unified Diff: chromeos/network/onc/onc_validator.cc

Issue 694533007: Add 'setProperties' to InternetOptionsHandler (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: . Created 6 years, 1 month ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: chromeos/network/onc/onc_validator.cc
diff --git a/chromeos/network/onc/onc_validator.cc b/chromeos/network/onc/onc_validator.cc
index 91cbd7af4bc5a6055317fec2f74443e4aa3c4e46..dd3f7ee4bd3699f747e96bf4cff3a9204239d3e3 100644
--- a/chromeos/network/onc/onc_validator.cc
+++ b/chromeos/network/onc/onc_validator.cc
@@ -403,13 +403,14 @@ bool Validator::RequireField(const base::DictionaryValue& dict,
const std::string& field_name) {
if (dict.HasKey(field_name))
return true;
- error_or_warning_found_ = true;
std::string message = MessageHeader() + "The required field '" + field_name +
"' is missing.";
- if (error_on_missing_field_)
+ if (error_on_missing_field_) {
+ error_or_warning_found_ = true;
pneubeck (no reviews) 2014/11/13 17:38:56 This will break a few unit tests. I uploaded a CL
stevenjb 2014/11/13 22:25:41 Thanks! I'll remove these changes from this CL.
LOG(ERROR) << message;
- else
- LOG(WARNING) << message;
+ } else {
+ VLOG(1) << message;
+ }
return false;
}

Powered by Google App Engine
This is Rietveld 408576698