Add 'setProperties' to InternetOptionsHandler

chromeos/network/onc/onc_validator.cc

 // Copyright (c) 2012 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #include "chromeos/network/onc/onc_validator.h"
 
 #include <algorithm>
 #include <string>
 
 #include "base/json/json_writer.h"
@@ skipping 385 matching lines @@
   LOG(ERROR) << MessageHeader() << "Found an empty string, but expected a "
              << "non-empty string.";
   path_.pop_back();
   return true;
 }
 
 bool Validator::RequireField(const base::DictionaryValue& dict,
                              const std::string& field_name) {
   if (dict.HasKey(field_name))
     return true;
-  error_or_warning_found_ = true;
   std::string message = MessageHeader() + "The required field '" + field_name +
       "' is missing.";
-  if (error_on_missing_field_)
+  if (error_on_missing_field_) {
+    error_or_warning_found_ = true;

[pneubeck (no reviews), 2014/11/13 17:38:56]

This will break a few unit tests.
I uploaded a CL to change this separately.

[stevenjb, 2014/11/13 22:25:41]

Thanks! I'll remove these changes from this CL.

     LOG(ERROR) << message;
-  else
-    LOG(WARNING) << message;
+  } else {
+    VLOG(1) << message;
+  }
   return false;
 }
 
 bool Validator::CheckGuidIsUniqueAndAddToSet(const base::DictionaryValue& dict,
                                              const std::string& key_guid,
                                              std::set<std::string> *guids) {
   std::string guid;
   if (dict.GetStringWithoutPathExpansion(key_guid, &guid)) {
     if (guids->count(guid) != 0) {
       error_or_warning_found_ = true;
@@ skipping 425 matching lines @@
 }
 
 std::string Validator::MessageHeader() {
   std::string path = path_.empty() ? "toplevel" : JoinString(path_, ".");
   std::string message = "At " + path + ": ";
   return message;
 }
 
 }  // namespace onc
 }  // namespace chromeos