chromeos/network/onc/onc_validator.h - Issue 694533007: Add 'setProperties' to InternetOptionsHandler

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: chromeos/network/onc/onc_validator.h

Issue 694533007: Add 'setProperties' to InternetOptionsHandler (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: . Created 6 years, 1 month ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: chromeos/network/onc/onc_validator.h

diff --git a/chromeos/network/onc/onc_validator.h b/chromeos/network/onc/onc_validator.h

index 1108b55fabe0d8aa301a9913b899086f6339286b..ff6fa1b4d3a77c27a57fa480c7f49ac62b9f3c59 100644

--- a/chromeos/network/onc/onc_validator.h

+++ b/chromeos/network/onc/onc_validator.h

@@ -38,7 +38,9 @@ struct OncValueSignature;

// - |managed_onc| is false and a field with name kRecommended is found

// (always ignored)

-// - a required field is missing (controlled by flag |error_on_missing_field|)

+// - a required field is missing. controlled by flag |error_on_missing_field|.

+// If true this is an error, if false a message is logged but no error or

+// warning is flagged.

// If one of these invalid cases occurs and, in case of a controlling flag, that

// flag is true, then it is an error. The function ValidateAndRepairObject sets