Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(435)

Issue 694503003: Implement conics for NVPR (Closed)

Created:
6 years, 1 month ago by Kimmo Kinnunen
Modified:
6 years, 1 month ago
Reviewers:
bsalomon, reed1
CC:
reviews_skia.org
Base URL:
https://skia.googlesource.com/skia.git@hairline-test-fix-unskip-nvpr
Project:
skia
Visibility:
Public.

Description

Implement conics for NVPR Implement conics for NVPR. Verified with currently disabled conicpaths gm, produces mostly same shapes with nvprmsaa4 and msaa4. BUG=skia:2033 Committed: https://skia.googlesource.com/skia/+/e097be50bdfac597119db2a170f96bae07dbcab1

Patch Set 1 #

Patch Set 2 : cleanup #

Total comments: 2

Patch Set 3 : address review comment #

Total comments: 1
Unified diffs Side-by-side diffs Delta from patch set Stats (+84 lines, -26 lines) Patch
M src/gpu/gl/GrGLDefines.h View 1 2 1 chunk +1 line, -0 lines 0 comments Download
M src/gpu/gl/GrGLPath.cpp View 1 2 4 chunks +83 lines, -26 lines 1 comment Download

Messages

Total messages: 10 (3 generated)
bsalomon
Do we not have a GM that exercises this? Maybe one should be added?
6 years, 1 month ago (2014-11-11 15:19:25 UTC) #2
Kimmo Kinnunen
On 2014/11/11 15:19:25, bsalomon wrote: > Do we not have a GM that exercises this? ...
6 years, 1 month ago (2014-11-12 06:24:13 UTC) #3
reed1
https://codereview.chromium.org/694503003/diff/20001/include/core/SkPath.h File include/core/SkPath.h (right): https://codereview.chromium.org/694503003/diff/20001/include/core/SkPath.h#newcode285 include/core/SkPath.h:285: int countConicWeights() const; ick ich, do we really need ...
6 years, 1 month ago (2014-11-12 14:06:39 UTC) #5
Kimmo Kinnunen
https://codereview.chromium.org/694503003/diff/20001/include/core/SkPath.h File include/core/SkPath.h (right): https://codereview.chromium.org/694503003/diff/20001/include/core/SkPath.h#newcode285 include/core/SkPath.h:285: int countConicWeights() const; On 2014/11/12 14:06:39, reed1 wrote: > ...
6 years, 1 month ago (2014-11-19 16:25:39 UTC) #6
bsalomon
lgtm https://codereview.chromium.org/694503003/diff/40001/src/gpu/gl/GrGLPath.cpp File src/gpu/gl/GrGLPath.cpp (right): https://codereview.chromium.org/694503003/diff/40001/src/gpu/gl/GrGLPath.cpp#newcode111 src/gpu/gl/GrGLPath.cpp:111: #ifndef SK_SCALAR_IS_FLOAT There is some interest in scalar=double. ...
6 years, 1 month ago (2014-11-19 16:53:33 UTC) #7
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/694503003/40001
6 years, 1 month ago (2014-11-20 06:40:50 UTC) #9
commit-bot: I haz the power
6 years, 1 month ago (2014-11-20 06:49:07 UTC) #10
Message was sent while issue was closed.
Committed patchset #3 (id:40001) as
https://skia.googlesource.com/skia/+/e097be50bdfac597119db2a170f96bae07dbcab1

Powered by Google App Engine
This is Rietveld 408576698