Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1003)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 694423002: Replace <link rel="import"> with <import> (Closed)

Created:
6 years, 1 month ago by abarth-chromium
Modified:
6 years, 1 month ago
Reviewers:
esprehn
CC:
esprehn, mojo-reviews_chromium.org, ojan
Base URL:
git@github.com:domokit/mojo.git@master
Project:
mojo
Visibility:
Public.

Description

Replace <link rel="import"> with <import> This CL is just a search-and-replace. R=esprehn@chromium.org Committed: https://chromium.googlesource.com/external/mojo/+/31a64e952eab2c8562f33f591b602ae79a09f78a

Patch Set 1 #

Total comments: 2
Unified diffs Side-by-side diffs Delta from patch set Stats (+157 lines, -159 lines) Patch
M sky/examples/city-list/city-list.sky View 1 chunk +4 lines, -6 lines 2 comments Download
M sky/examples/city-list/index.sky View 1 chunk +1 line, -1 line 0 comments Download
M sky/framework/README.md View 1 chunk +1 line, -1 line 0 comments Download
M sky/framework/inspector/inspector.sky View 1 chunk +11 lines, -11 lines 0 comments Download
M sky/framework/inspector/runtime-agent.sky View 1 chunk +1 line, -1 line 0 comments Download
M sky/framework/shell.sky View 1 chunk +2 lines, -2 lines 0 comments Download
M sky/framework/sky-element/TemplateBinding.sky View 1 chunk +1 line, -1 line 0 comments Download
M sky/framework/sky-element/sky-element.sky View 1 chunk +1 line, -1 line 0 comments Download
M sky/framework/xmlhttprequest.sky View 1 chunk +5 lines, -5 lines 0 comments Download
M sky/tests/custom-elements/constructor-calls-created-synchronously.sky View 1 chunk +2 lines, -2 lines 0 comments Download
M sky/tests/custom-elements/document-register-basic.sky View 1 chunk +2 lines, -2 lines 0 comments Download
M sky/tests/custom-elements/document-register-reentrant-null-constructor.sky View 1 chunk +2 lines, -2 lines 0 comments Download
M sky/tests/custom-elements/document-register-reentrant-returning-fake.sky View 1 chunk +2 lines, -2 lines 0 comments Download
M sky/tests/custom-elements/document-register-reentrant-throwing-constructor.sky View 1 chunk +2 lines, -2 lines 0 comments Download
M sky/tests/custom-elements/element-upgrade-no-register-and-leak.sky View 1 chunk +1 line, -1 line 0 comments Download
M sky/tests/custom-elements/html-element-type-extension-assert.sky View 1 chunk +1 line, -1 line 0 comments Download
M sky/tests/custom-elements/lifecycle-created-createElement-recursion.sky View 1 chunk +1 line, -1 line 0 comments Download
M sky/tests/custom-elements/lifecycle-created-createElement-reentrancy.sky View 1 chunk +2 lines, -2 lines 0 comments Download
M sky/tests/custom-elements/lifecycle-created-parser-script.sky View 1 chunk +2 lines, -2 lines 0 comments Download
M sky/tests/framework/observe.sky View 1 chunk +3 lines, -3 lines 0 comments Download
M sky/tests/inspector/css-computed-style.sky View 1 chunk +2 lines, -2 lines 0 comments Download
M sky/tests/inspector/dom-mutation.sky View 1 chunk +2 lines, -2 lines 0 comments Download
M sky/tests/inspector/dom-mutation-modify-text-node-and-append.sky View 1 chunk +1 line, -1 line 0 comments Download
M sky/tests/lowlevel/abarth.sky View 1 chunk +1 line, -1 line 0 comments Download
M sky/tests/lowlevel/attribute-collection.sky View 1 chunk +2 lines, -2 lines 0 comments Download
M sky/tests/lowlevel/camel-case.sky View 1 chunk +2 lines, -2 lines 0 comments Download
M sky/tests/lowlevel/createElement.sky View 1 chunk +2 lines, -2 lines 0 comments Download
M sky/tests/lowlevel/dom-implementation-create-document.sky View 1 chunk +2 lines, -2 lines 0 comments Download
M sky/tests/lowlevel/hello-world.sky View 1 chunk +1 line, -1 line 0 comments Download
M sky/tests/lowlevel/query-selector.sky View 1 chunk +2 lines, -2 lines 0 comments Download
M sky/tests/lowlevel/scrollbar.sky View 1 chunk +1 line, -1 line 0 comments Download
M sky/tests/lowlevel/style-basic.sky View 1 chunk +1 line, -1 line 0 comments Download
M sky/tests/lowlevel/style-specificity.sky View 1 chunk +2 lines, -2 lines 0 comments Download
M sky/tests/lowlevel/text.sky View 1 chunk +1 line, -1 line 0 comments Download
M sky/tests/mocha/describe-only.sky View 1 chunk +2 lines, -2 lines 0 comments Download
M sky/tests/mocha/it-only.sky View 1 chunk +2 lines, -2 lines 0 comments Download
M sky/tests/mutation-observer/callback-arguments.sky View 1 chunk +2 lines, -2 lines 0 comments Download
M sky/tests/mutation-observer/clear-transient-without-delivery.sky View 1 chunk +2 lines, -2 lines 0 comments Download
M sky/tests/mutation-observer/create-during-delivery.sky View 1 chunk +2 lines, -2 lines 0 comments Download
M sky/tests/mutation-observer/cross-document.sky View 1 chunk +2 lines, -2 lines 0 comments Download
M sky/tests/mutation-observer/delivery-order.sky View 1 chunk +2 lines, -2 lines 0 comments Download
M sky/tests/mutation-observer/disconnect-cancel-pending.sky View 1 chunk +2 lines, -2 lines 0 comments Download
M sky/tests/mutation-observer/document-fragment-insertion.sky View 1 chunk +2 lines, -2 lines 0 comments Download
M sky/tests/mutation-observer/mutate-during-delivery.sky View 1 chunk +2 lines, -2 lines 0 comments Download
M sky/tests/mutation-observer/mutation-callback-non-element-crash.sky View 1 chunk +1 line, -1 line 0 comments Download
M sky/tests/mutation-observer/mutation-observer-constructor.sky View 1 chunk +2 lines, -2 lines 0 comments Download
M sky/tests/mutation-observer/mutation-record-constructor.sky View 1 chunk +2 lines, -2 lines 0 comments Download
M sky/tests/mutation-observer/mutation-record-nullity.sky View 1 chunk +2 lines, -2 lines 0 comments Download
M sky/tests/mutation-observer/observe-attributes.sky View 1 chunk +2 lines, -2 lines 0 comments Download
M sky/tests/mutation-observer/observe-characterdata.sky View 1 chunk +2 lines, -2 lines 0 comments Download
M sky/tests/mutation-observer/observe-childList.sky View 1 chunk +2 lines, -2 lines 0 comments Download
M sky/tests/mutation-observer/observe-exceptions.sky View 1 chunk +2 lines, -2 lines 0 comments Download
M sky/tests/mutation-observer/observe-options-attributes.sky View 1 chunk +2 lines, -2 lines 0 comments Download
M sky/tests/mutation-observer/observe-options-character-data.sky View 1 chunk +2 lines, -2 lines 0 comments Download
M sky/tests/mutation-observer/observe-subtree.sky View 1 chunk +2 lines, -2 lines 0 comments Download
M sky/tests/mutation-observer/observer-wrapper-dropoff-transient.sky View 1 chunk +2 lines, -2 lines 0 comments Download
M sky/tests/mutation-observer/script-append.sky View 1 chunk +2 lines, -2 lines 0 comments Download
M sky/tests/mutation-observer/shadow-dom.sky View 1 chunk +2 lines, -2 lines 0 comments Download
M sky/tests/mutation-observer/takeRecords.sky View 1 chunk +2 lines, -2 lines 0 comments Download
M sky/tests/parser/comments.sky View 1 chunk +1 line, -1 line 0 comments Download
M sky/tests/parser/control.sky View 1 chunk +1 line, -1 line 0 comments Download
M sky/tests/parser/control-expected.txt View 1 chunk +1 line, -1 line 0 comments Download
M sky/tests/parser/endtag.sky View 1 chunk +1 line, -1 line 0 comments Download
M sky/tests/parser/endtag-expected.txt View 1 chunk +1 line, -1 line 0 comments Download
M sky/tests/parser/entity.sky View 1 chunk +1 line, -1 line 0 comments Download
M sky/tests/parser/entity-expected.txt View 1 chunk +1 line, -1 line 0 comments Download
M sky/tests/parser/html.sky View 1 chunk +1 line, -1 line 0 comments Download
M sky/tests/parser/html-expected.txt View 1 chunk +1 line, -1 line 0 comments Download
M sky/tests/parser/normaliser-crlf.sky View 1 chunk +1 line, -1 line 0 comments Download
M sky/tests/parser/normaliser-crlf-expected.txt View 1 chunk +1 line, -1 line 0 comments Download
M sky/tests/parser/normaliser-null-expected.txt View 1 chunk +1 line, -1 line 0 comments Download
M sky/tests/parser/script.sky View 1 chunk +1 line, -1 line 0 comments Download
M sky/tests/parser/script-expected.txt View 1 chunk +1 line, -1 line 0 comments Download
M sky/tests/parser/starttag.sky View 1 chunk +1 line, -1 line 0 comments Download
M sky/tests/parser/starttag-expected.txt View 1 chunk +1 line, -1 line 0 comments Download
M sky/tests/parser/style.sky View 1 chunk +1 line, -1 line 0 comments Download
M sky/tests/parser/style-expected.txt View 1 chunk +1 line, -1 line 0 comments Download
M sky/tests/parser/voidtag.sky View 1 chunk +1 line, -1 line 0 comments Download
M sky/tests/parser/voidtag-expected.txt View 1 chunk +1 line, -1 line 0 comments Download
M sky/tests/services/buffer.sky View 1 chunk +2 lines, -2 lines 0 comments Download
M sky/tests/services/codec.sky View 1 chunk +2 lines, -2 lines 0 comments Download
M sky/tests/services/core.sky View 1 chunk +2 lines, -2 lines 0 comments Download
M sky/tests/services/network.sky View 1 chunk +6 lines, -6 lines 0 comments Download
M sky/tests/services/xhr.sky View 1 chunk +3 lines, -3 lines 0 comments Download
M sky/tests/styles/border-parsing.sky View 1 chunk +2 lines, -2 lines 0 comments Download
M sky/tests/styles/inline-style.sky View 1 chunk +2 lines, -2 lines 0 comments Download

Messages

Total messages: 4 (0 generated)
abarth-chromium
6 years, 1 month ago (2014-11-03 19:31:03 UTC) #1
esprehn
lgtm, but you have a typo. https://codereview.chromium.org/694423002/diff/1/sky/examples/city-list/city-list.sky File sky/examples/city-list/city-list.sky (right): https://codereview.chromium.org/694423002/diff/1/sky/examples/city-list/city-list.sky#newcode6 sky/examples/city-list/city-list.sky:6: <import src="import" href="../../framework/sky-element/sky-element.sky" ...
6 years, 1 month ago (2014-11-03 20:19:27 UTC) #2
abarth-chromium
https://codereview.chromium.org/694423002/diff/1/sky/examples/city-list/city-list.sky File sky/examples/city-list/city-list.sky (right): https://codereview.chromium.org/694423002/diff/1/sky/examples/city-list/city-list.sky#newcode6 sky/examples/city-list/city-list.sky:6: <import src="import" href="../../framework/sky-element/sky-element.sky" as="SkyElement" /> On 2014/11/03 at 20:19:26, ...
6 years, 1 month ago (2014-11-03 20:25:19 UTC) #3
abarth-chromium
6 years, 1 month ago (2014-11-03 20:35:01 UTC) #4
Message was sent while issue was closed. 
Committed patchset #1 (id:1) manually as
31a64e952eab2c8562f33f591b602ae79a09f78a (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698