sky/tests/mutation-observer/mutation-callback-non-element-crash.sky - Issue 694423002: Replace <link rel="import"> with <import>

Side by Side Diff

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Side by Side Diff: sky/tests/mutation-observer/mutation-callback-non-element-crash.sky

Issue 694423002: Replace <link rel="import"> with <import> (Closed) Base URL: git@github.com:domokit/mojo.git@master

Patch Set: Created 6 years, 1 month ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

OLD	NEW
1 <html>	1 <html>

2 <link rel="import" href="../resources/dump-as-text.sky" />	2 <import src="../resources/dump-as-text.sky" />

3 <body id="body">	3 <body id="body">

4 <script>	4 <script>

5 function mutationCallback(mutations, observer) {	5 function mutationCallback(mutations, observer) {

6 mutations[0].addedNodes[-1];	6 mutations[0].addedNodes[-1];

7 }	7 }

8	8

9 var mutationObserver = new MutationObserver(mutationCallback);	9 var mutationObserver = new MutationObserver(mutationCallback);

10 var body = document.getElementById("body");	10 var body = document.getElementById("body");

11 mutationObserver.observe(body, {childList: true});	11 mutationObserver.observe(body, {childList: true});

12 body.appendChild(document.createTextNode("PASS. We didn't crash"));	12 body.appendChild(document.createTextNode("PASS. We didn't crash"));

13 </script>	13 </script>

14 </body>	14 </body>

15 </html>	15 </html>

OLD	NEW