sky/tests/inspector/dom-mutation-modify-text-node-and-append.sky - Issue 694423002: Replace <link rel="import"> with <import>

Side by Side Diff

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Side by Side Diff: sky/tests/inspector/dom-mutation-modify-text-node-and-append.sky

Issue 694423002: Replace <link rel="import"> with <import> (Closed) Base URL: git@github.com:domokit/mojo.git@master

Patch Set: Created 6 years, 1 month ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

OLD	NEW
1 <html>	1 <html>

2 <link rel="import" href="/sky/framework/inspector/dom-agent.sky" as="DOMAgent" / >	2 <import src="/sky/framework/inspector/dom-agent.sky" as="DOMAgent" />

3 <div></div>	3 <div></div>

4 <script>	4 <script>

5 // FIXME: This shows a bug in our DOM mutation handling, we should	5 // FIXME: This shows a bug in our DOM mutation handling, we should

6 // only get one childNodeInserted record here, but we get two, which	6 // only get one childNodeInserted record here, but we get two, which

7 // means the inspector shows two nodes where it should only show one.	7 // means the inspector shows two nodes where it should only show one.

8	8

9 // setTimeout to flush pending DOM modifications and measure	9 // setTimeout to flush pending DOM modifications and measure

10 // only the changes we want to.	10 // only the changes we want to.

11 setTimeout(function() {	11 setTimeout(function() {

12 var delegate = {	12 var delegate = {

(...skipping 12 matching lines...) Expand all Loading...
25 var adding = document.createElement('adding');	25 var adding = document.createElement('adding');

26 document.querySelector('div').appendChild(adding);	26 document.querySelector('div').appendChild(adding);

27 adding.textContent = 'adding';	27 adding.textContent = 'adding';

28	28

29 setTimeout(function() {	29 setTimeout(function() {

30 internals.notifyTestComplete(internals.contentAsText());	30 internals.notifyTestComplete(internals.contentAsText());

31 });	31 });

32 });	32 });

33 </script>	33 </script>

34 </html>	34 </html>

OLD	NEW