Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(73)

Issue 693893006: Roll BoringSSL. (Closed)

Created:
6 years, 1 month ago by davidben
Modified:
6 years, 1 month ago
Reviewers:
agl
CC:
chromium-reviews
Base URL:
https://chromium.googlesource.com/chromium/src.git@nasm
Project:
chromium
Visibility:
Public.

Description

Roll BoringSSL. This includes several fixes from BoringSSL: - d2i_AutoPrivateKey stopped working - Use RtlGenRandom on Windows since it works in the sandbox - Assemble Win64 on Yasm; GYP and Ninja do not have build-in rules for ml64.exe. This fixes the boringssl_unittests build on Win64. Full list of changes pulled below: 817ec34 Rename example_sign to evp_test. 8fb1921 Allow PKCS#8 in d2i_AutoPrivateKey. dfc2948 Call RtlGenRandom directly in RAND_bytes. 0e2a3cf Remove KSSL_DEBUG. cf2d4f4 Test renegotiation with BoringSSL as the client. ec48af4 Make SSL_MODE_AUTO_RETRY the default. 8cfd8ad Remove unused EVP_PKEY_ASN1_METHODs and flags. 029a779 Remove BN_LONG macro. 2a0ee11 Remove remnants of EVP_MD_FLAG_PKEY_METHOD_SIGNATURE. a0ca1b7 DTLS1_AD_MISSING_HANDSHAKE_MESSAGE does not exist. be700c6 Remove remnant of MS SGC second ClientHello. 2ae77d2 Test server-side renegotiation. 8b1d900 Fix unused variables in bn/generic.c bc786a9 Build with yasm on Win64 as well. eee7306 Get bssl tool building on Windows. f44aa68 Fix standalone Win64 build. e92fc18 Remove remnant of SRP. fd617a5 Port ssl3_{get,send}_server_key_exchange to EVP_Digest{Verify,Sign}*. e6def37 Remove ERR_LIB_PKCS12. BUG=338884, 429919, 428671 Committed: https://crrev.com/6e8ed1298508737a338bdb2e31773a35f68c4bc7 Cr-Commit-Position: refs/heads/master@{#302901}

Patch Set 1 #

Patch Set 2 : roll further #

Unified diffs Side-by-side diffs Delta from patch set Stats (+10557 lines, -10598 lines) Patch
M DEPS View 1 1 chunk +1 line, -1 line 0 comments Download
M third_party/boringssl/BUILD.gn View 2 chunks +9 lines, -4 lines 0 comments Download
M third_party/boringssl/boringssl.gyp View 2 chunks +10 lines, -2 lines 0 comments Download
M third_party/boringssl/boringssl_tests.gypi View 1 2 chunks +3 lines, -3 lines 0 comments Download
M third_party/boringssl/boringssl_unittest.cc View 1 1 chunk +2 lines, -2 lines 0 comments Download
M third_party/boringssl/update_gypi_and_asm.py View 1 chunk +1 line, -1 line 0 comments Download
M third_party/boringssl/win-x86_64/crypto/aes/aes-x86_64.asm View 39 chunks +1750 lines, -1756 lines 0 comments Download
M third_party/boringssl/win-x86_64/crypto/aes/aesni-x86_64.asm View 77 chunks +1590 lines, -1598 lines 0 comments Download
M third_party/boringssl/win-x86_64/crypto/aes/bsaes-x86_64.asm View 28 chunks +1106 lines, -1107 lines 0 comments Download
M third_party/boringssl/win-x86_64/crypto/aes/vpaes-x86_64.asm View 29 chunks +483 lines, -489 lines 0 comments Download
M third_party/boringssl/win-x86_64/crypto/bn/modexp512-x86_64.asm View 99 chunks +549 lines, -551 lines 0 comments Download
M third_party/boringssl/win-x86_64/crypto/bn/rsaz-avx2.asm View 1 chunk +22 lines, -21 lines 0 comments Download
M third_party/boringssl/win-x86_64/crypto/bn/rsaz-x86_64.asm View 39 chunks +521 lines, -527 lines 0 comments Download
M third_party/boringssl/win-x86_64/crypto/bn/x86_64-mont.asm View 13 chunks +402 lines, -406 lines 0 comments Download
M third_party/boringssl/win-x86_64/crypto/bn/x86_64-mont5.asm View 38 chunks +785 lines, -790 lines 0 comments Download
M third_party/boringssl/win-x86_64/crypto/cpu-x86_64-asm.asm View 3 chunks +65 lines, -65 lines 0 comments Download
M third_party/boringssl/win-x86_64/crypto/md5/md5-x86_64.asm View 21 chunks +234 lines, -236 lines 0 comments Download
M third_party/boringssl/win-x86_64/crypto/modes/aesni-gcm-x86_64.asm View 1 chunk +11 lines, -10 lines 0 comments Download
M third_party/boringssl/win-x86_64/crypto/modes/ghash-x86_64.asm View 36 chunks +512 lines, -515 lines 0 comments Download
M third_party/boringssl/win-x86_64/crypto/rc4/rc4-md5-x86_64.asm View 6 chunks +509 lines, -511 lines 0 comments Download
M third_party/boringssl/win-x86_64/crypto/rc4/rc4-x86_64.asm View 7 chunks +419 lines, -422 lines 0 comments Download
M third_party/boringssl/win-x86_64/crypto/sha/sha1-x86_64.asm View 108 chunks +697 lines, -700 lines 0 comments Download
M third_party/boringssl/win-x86_64/crypto/sha/sha256-x86_64.asm View 159 chunks +484 lines, -487 lines 0 comments Download
M third_party/boringssl/win-x86_64/crypto/sha/sha512-x86_64.asm View 116 chunks +392 lines, -394 lines 0 comments Download

Messages

Total messages: 7 (2 generated)
davidben
Note: this depends on https://codereview.chromium.org/684093011/
6 years, 1 month ago (2014-11-05 18:51:56 UTC) #2
agl
lgtm
6 years, 1 month ago (2014-11-05 18:55:39 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/693893006/20001
6 years, 1 month ago (2014-11-05 22:34:46 UTC) #5
commit-bot: I haz the power
Committed patchset #2 (id:20001)
6 years, 1 month ago (2014-11-05 23:35:40 UTC) #6
commit-bot: I haz the power
6 years, 1 month ago (2014-11-05 23:36:34 UTC) #7
Message was sent while issue was closed.
Patchset 2 (id:??) landed as
https://crrev.com/6e8ed1298508737a338bdb2e31773a35f68c4bc7
Cr-Commit-Position: refs/heads/master@{#302901}

Powered by Google App Engine
This is Rietveld 408576698