Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(475)

Issue 684093011: Disable size_t truncation warning (C4267) on BoringSSL Win64. (Closed)

Created:
6 years, 1 month ago by davidben
Modified:
6 years, 1 month ago
Reviewers:
agl
CC:
chromium-reviews
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Project:
chromium
Visibility:
Public.

Description

Disable size_t truncation warning (C4267) on BoringSSL Win64. There's a ton of them; OpenSSL is very far from being size_t-clean. Disable the warning (as in the standalone build's cmake setup) until we get a handle on it in BoringSSL. BUG=429039, 167187 Committed: https://crrev.com/d6461f32e4e9c7274083604cd30290c1739b91fb Cr-Commit-Position: refs/heads/master@{#302857}

Patch Set 1 #

Patch Set 2 : update_gypi_and_asm.py #

Unified diffs Side-by-side diffs Delta from patch set Stats (+78 lines, -0 lines) Patch
M third_party/boringssl/BUILD.gn View 1 chunk +6 lines, -0 lines 0 comments Download
M third_party/boringssl/boringssl.gyp View 1 chunk +3 lines, -0 lines 0 comments Download
M third_party/boringssl/boringssl_tests.gypi View 1 22 chunks +66 lines, -0 lines 0 comments Download
M third_party/boringssl/update_gypi_and_asm.py View 1 chunk +3 lines, -0 lines 0 comments Download

Messages

Total messages: 7 (2 generated)
davidben
Turns out this is still not sufficient to get things building on Win64, but it's ...
6 years, 1 month ago (2014-10-31 19:00:42 UTC) #2
agl
LGTM. (P.s. if I've not replied to a CL in days but am otherwise responsive ...
6 years, 1 month ago (2014-11-05 18:53:50 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/684093011/20001
6 years, 1 month ago (2014-11-05 19:24:53 UTC) #5
commit-bot: I haz the power
Committed patchset #2 (id:20001)
6 years, 1 month ago (2014-11-05 20:11:50 UTC) #6
commit-bot: I haz the power
6 years, 1 month ago (2014-11-05 20:13:43 UTC) #7
Message was sent while issue was closed.
Patchset 2 (id:??) landed as
https://crrev.com/d6461f32e4e9c7274083604cd30290c1739b91fb
Cr-Commit-Position: refs/heads/master@{#302857}

Powered by Google App Engine
This is Rietveld 408576698