Don't show media controls on "focusin" when controls are disabled.

Don't show media controls on focus if 'controls' is not set.

Previously when an HTMLMediaElement received focus, the media controls
would be shown regardless of whether 'controls' was set.
It's possible for an HTMLMediaElement to receive focus despite not having
'controls' set, if it has a 'tabindex'.

BUG=424625
Committed: https://src.chromium.org/viewvc/blink?view=rev&revision=184803

[watk, 2014-10-29 21:50:42]

watk@chromium.org changed reviewers:
+ fs@opera.com

[watk, 2014-10-29 21:50:42]

watk@chromium.org changed required reviewers:
+ fs@opera.com

[watk, 2014-10-30 00:52:51]

fs@: I don't yet have access to the try server, but I'll try this change when I
do.

[fs, 2014-10-30 12:47:40]

fs@opera.com changed reviewers:
+ philipj@opera.com

[fs, 2014-10-30 12:47:40]

LGTM, thanks.

I had to think about which side the predicate check should be on for a while,
and ended up siding with you (because of the generic name of the method called).
I'm adding philipj in case he has a different opinion (maybe it'd be better to
rename the MediaControls method to "showOnFocus" or something, and then check on
the HTMLMediaElement side.)

[philipj_slow, 2014-10-30 14:12:10]

LGTM too.

I also think it's a little bit odd to use mediaElement().shouldShowControls() in
MediaControls, but the other focus logic is in
MediaControls::shouldHideMediaControls so I can live with that.

[watk, 2014-11-03 21:42:18]

The CQ bit was checked by watk@chromium.org

[commit-bot: I haz the power, 2014-11-03 21:42:52]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/692643002/40001

[watk, 2014-11-03 21:51:47]

Thanks for the reviews! The try failure was unrelated, so I enabled the CQ.

[commit-bot: I haz the power, 2014-11-03 21:56:26]

Committed patchset #3 (id:40001) as 184803