Source/core/html/shadow/MediaControls.cpp - Issue 692643002: Don't show media controls on "focusin" when controls are disabled.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: Source/core/html/shadow/MediaControls.cpp

Issue 692643002: Don't show media controls on "focusin" when controls are disabled. (Closed) Base URL: https://chromium.googlesource.com/chromium/blink.git@master

Patch Set: Fix whitespace in test expected output Created 6 years, 2 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

Index: Source/core/html/shadow/MediaControls.cpp

diff --git a/Source/core/html/shadow/MediaControls.cpp b/Source/core/html/shadow/MediaControls.cpp

index f7163b2c6d82a56110a4ac8005991e8348a793a7..c3d51dfd8d9fe0f0f8598a1e2f29635f1097bfef 100644

--- a/Source/core/html/shadow/MediaControls.cpp

+++ b/Source/core/html/shadow/MediaControls.cpp

@@ -220,8 +220,10 @@ void MediaControls::show()

void MediaControls::mediaElementFocused()

{

- show();

- resetHideMediaControlsTimer();

+ if (mediaElement().shouldShowControls()) {

+ show();

+ resetHideMediaControlsTimer();

+ }

}

void MediaControls::hide()

« no previous file with comments | « LayoutTests/media/video-controls-dont-show-on-focus-when-disabled-expected.txt ('k') | no next file » | no next file with comments »