Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(23)

Unified Diff: LayoutTests/media/video-controls-dont-show-on-focus-when-disabled.html

Issue 692643002: Don't show media controls on "focusin" when controls are disabled. (Closed) Base URL: https://chromium.googlesource.com/chromium/blink.git@master
Patch Set: Fix whitespace in test expected output Created 6 years, 2 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « no previous file | LayoutTests/media/video-controls-dont-show-on-focus-when-disabled-expected.txt » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: LayoutTests/media/video-controls-dont-show-on-focus-when-disabled.html
diff --git a/LayoutTests/media/video-controls-show-on-focus.html b/LayoutTests/media/video-controls-dont-show-on-focus-when-disabled.html
similarity index 60%
copy from LayoutTests/media/video-controls-show-on-focus.html
copy to LayoutTests/media/video-controls-dont-show-on-focus-when-disabled.html
index 402c33a07e48ebc9ec74f4aa6f826855bd14ed0b..346ecb65d9ef3e775bf875cd0d0e1da908d2efc5 100644
--- a/LayoutTests/media/video-controls-show-on-focus.html
+++ b/LayoutTests/media/video-controls-dont-show-on-focus-when-disabled.html
@@ -4,9 +4,11 @@
<script src=video-test.js></script>
<script src=media-controls.js></script>
<p>
-Test that video controls re-appear when the media (&lt;video>) element is focused.
+Test that video controls don't appear when the media (&lt;video>) element is
+focused and the 'controls' attribute is not set.
</p>
-<video controls autoplay src="content/test.ogv"></video>
+<!-- 'tabindex' makes the video focusable despite it not having controls -->
+<video tabindex="0" autoplay src="content/test.ogv"></video>
<script>
var controls;
var video = document.querySelector("video");
@@ -17,14 +19,8 @@ video.addEventListener("playing", function()
{
controls = mediaControlsButton(video, "panel");
- testExpected("getComputedStyle(controls).opacity", 0);
video.focus();
-
- testExpected("getComputedStyle(controls).opacity", 1);
-
- // We fade out when focus is lost, so the opacity is still 1
- video.blur();
- testExpected("getComputedStyle(controls).opacity", 1);
+ testExpected("getComputedStyle(controls).opacity", 0);
endTest();
}, video);
« no previous file with comments | « no previous file | LayoutTests/media/video-controls-dont-show-on-focus-when-disabled-expected.txt » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698