Provide a way to disable libpci dependency.

Provide a way to disable libpci dependency.

Add a new gyp variable: use_libpci (default value is 1).
Add a new define when use_libpci==1: USE_LIBPCI.
Don't call specific PCI code in gpu_info_collector_linux.cc if USE_LIBPCI isn't defined.

BUG=427401
R=dnicoara@chromium.org

[bedupontcisco_gmail.com, 2014-10-29 15:24:56]

bedupontcisco@gmail.com changed reviewers:
+ piman@chromium.org, sievers@chromium.org

[dnicoara, 2014-10-29 15:34:01]

You should remove the NOTRY=true so that the bots can verify the change.

https://codereview.chromium.org/692543002/diff/1/gpu/config/gpu_info_collecto...
File gpu/config/gpu_info_collector_linux.cc (right):

https://codereview.chromium.org/692543002/diff/1/gpu/config/gpu_info_collecto...
gpu/config/gpu_info_collector_linux.cc:20: #if defined(USE_LIBPCI)
#ifdef-ed libraries should be the last included libraries.

[piman, 2014-10-29 17:17:04]

https://codereview.chromium.org/692543002/diff/20001/AUTHORS
File AUTHORS (right):

https://codereview.chromium.org/692543002/diff/20001/AUTHORS#newcode65
AUTHORS:65: Benjamin Dupont <bedupont@cisco.com>
For contributions, we need a Contributor License Agreement, and I can't find a
record for you or your company.

Please either sign the individual CLA
(https://cla.developers.google.com/about/google-individual) if contributing as
an individual, or have your company submit a corporate CLA
(https://developers.google.com/open-source/cla/corporate) if submitting on
behalf of your company.

Also, please use the named email address to upload your change.

[bedupontcisco_gmail.com, 2014-10-29 20:25:35]

On 2014/10/29 17:17:04, piman (Very slow to review) wrote:
> https://codereview.chromium.org/692543002/diff/20001/AUTHORS
> File AUTHORS (right):
> 
> https://codereview.chromium.org/692543002/diff/20001/AUTHORS#newcode65
> AUTHORS:65: Benjamin Dupont <mailto:bedupont@cisco.com>
> For contributions, we need a Contributor License Agreement, and I can't find a
> record for you or your company.
> 
> Please either sign the individual CLA
> (https://cla.developers.google.com/about/google-individual) if contributing as
> an individual, or have your company submit a corporate CLA
> (https://developers.google.com/open-source/cla/corporate) if submitting on
> behalf of your company.
> 
> Also, please use the named email address to upload your change.

We've already recorded a corporate CLA with specific contributors and I should
be in this list. I have a question about that (because it isn't the first time
that we asked it): should we add the company domain name with a wildcard at the
end of the file or may be should we add all authorized address emails?

[piman, 2014-10-29 20:55:04]

On 2014/10/29 20:25:35, Benjamin Dupont wrote:
> On 2014/10/29 17:17:04, piman (Very slow to review) wrote:
> > https://codereview.chromium.org/692543002/diff/20001/AUTHORS
> > File AUTHORS (right):
> > 
> > https://codereview.chromium.org/692543002/diff/20001/AUTHORS#newcode65
> > AUTHORS:65: Benjamin Dupont <mailto:bedupont@cisco.com>
> > For contributions, we need a Contributor License Agreement, and I can't find
a
> > record for you or your company.
> > 
> > Please either sign the individual CLA
> > (https://cla.developers.google.com/about/google-individual) if contributing
as
> > an individual, or have your company submit a corporate CLA
> > (https://developers.google.com/open-source/cla/corporate) if submitting on
> > behalf of your company.
> > 
> > Also, please use the named email address to upload your change.
> 
> We've already recorded a corporate CLA with specific contributors and I should
> be in this list.

Ah, double-checked, I found you.

> I have a question about that (because it isn't the first time
> that we asked it): should we add the company domain name with a wildcard at
the
> end of the file or may be should we add all authorized address emails?

Because the CLA doesn't have a wildcard, let's have any contributor add
themselves to the AUTHORS file explicitly.

[piman, 2014-10-29 20:56:06]

On 2014/10/29 20:55:04, piman (Very slow to review) wrote:
> On 2014/10/29 20:25:35, Benjamin Dupont wrote:
> > On 2014/10/29 17:17:04, piman (Very slow to review) wrote:
> > > https://codereview.chromium.org/692543002/diff/20001/AUTHORS
> > > File AUTHORS (right):
> > > 
> > > https://codereview.chromium.org/692543002/diff/20001/AUTHORS#newcode65
> > > AUTHORS:65: Benjamin Dupont <mailto:bedupont@cisco.com>
> > > For contributions, we need a Contributor License Agreement, and I can't
find
> a
> > > record for you or your company.
> > > 
> > > Please either sign the individual CLA
> > > (https://cla.developers.google.com/about/google-individual) if
contributing
> as
> > > an individual, or have your company submit a corporate CLA
> > > (https://developers.google.com/open-source/cla/corporate) if submitting on
> > > behalf of your company.
> > > 
> > > Also, please use the named email address to upload your change.
> > 
> > We've already recorded a corporate CLA with specific contributors and I
should
> > be in this list.
> 
> Ah, double-checked, I found you.

And, sorry about that, but, could you upload this CL from your @cisco.com email?

> 
> > I have a question about that (because it isn't the first time
> > that we asked it): should we add the company domain name with a wildcard at
> the
> > end of the file or may be should we add all authorized address emails?
> 
> Because the CLA doesn't have a wildcard, let's have any contributor add
> themselves to the AUTHORS file explicitly.

[piman, 2014-10-29 21:01:52]

https://codereview.chromium.org/692543002/diff/20001/gpu/config/BUILD.gn
File gpu/config/BUILD.gn (right):

https://codereview.chromium.org/692543002/diff/20001/gpu/config/BUILD.gn#newc...
gpu/config/BUILD.gn:65: if (is_linux && use_libpci && (use_x11 || use_ozone)) {
I think you need to declare use_libpci in build/config/features.gni or
something.

[bedupontcisco_gmail.com, 2014-10-29 21:19:47]

On 2014/10/29 20:56:06, piman (Very slow to review) wrote:
> On 2014/10/29 20:55:04, piman (Very slow to review) wrote:
> > On 2014/10/29 20:25:35, Benjamin Dupont wrote:
> > > On 2014/10/29 17:17:04, piman (Very slow to review) wrote:
> > > > https://codereview.chromium.org/692543002/diff/20001/AUTHORS
> > > > File AUTHORS (right):
> > > > 
> > > > https://codereview.chromium.org/692543002/diff/20001/AUTHORS#newcode65
> > > > AUTHORS:65: Benjamin Dupont <mailto:bedupont@cisco.com>
> > > > For contributions, we need a Contributor License Agreement, and I can't
> find
> > a
> > > > record for you or your company.
> > > > 
> > > > Please either sign the individual CLA
> > > > (https://cla.developers.google.com/about/google-individual) if
> contributing
> > as
> > > > an individual, or have your company submit a corporate CLA
> > > > (https://developers.google.com/open-source/cla/corporate) if submitting
on
> > > > behalf of your company.
> > > > 
> > > > Also, please use the named email address to upload your change.
> > > 
> > > We've already recorded a corporate CLA with specific contributors and I
> should
> > > be in this list.
> > 
> > Ah, double-checked, I found you.
> 
> And, sorry about that, but, could you upload this CL from your @cisco.com
email?
> 
NP, I think I uploaded this CL with my cisco address (I had to change my
security gmail account which is bound with my Cisco address email to allow it),
I'll double check tomorrow morning.
> > 
> > > I have a question about that (because it isn't the first time
> > > that we asked it): should we add the company domain name with a wildcard
at
> > the
> > > end of the file or may be should we add all authorized address emails?
> > 
> > Because the CLA doesn't have a wildcard, let's have any contributor add
> > themselves to the AUTHORS file explicitly.
Thanks for this clarification.

[piman, 2014-10-29 21:21:41]

On 2014/10/29 21:19:47, Benjamin Dupont wrote:
> On 2014/10/29 20:56:06, piman (Very slow to review) wrote:
> > On 2014/10/29 20:55:04, piman (Very slow to review) wrote:
> > > On 2014/10/29 20:25:35, Benjamin Dupont wrote:
> > > > On 2014/10/29 17:17:04, piman (Very slow to review) wrote:
> > > > > https://codereview.chromium.org/692543002/diff/20001/AUTHORS
> > > > > File AUTHORS (right):
> > > > > 
> > > > > https://codereview.chromium.org/692543002/diff/20001/AUTHORS#newcode65
> > > > > AUTHORS:65: Benjamin Dupont <mailto:bedupont@cisco.com>
> > > > > For contributions, we need a Contributor License Agreement, and I
can't
> > find
> > > a
> > > > > record for you or your company.
> > > > > 
> > > > > Please either sign the individual CLA
> > > > > (https://cla.developers.google.com/about/google-individual) if
> > contributing
> > > as
> > > > > an individual, or have your company submit a corporate CLA
> > > > > (https://developers.google.com/open-source/cla/corporate) if
submitting
> on
> > > > > behalf of your company.
> > > > > 
> > > > > Also, please use the named email address to upload your change.
> > > > 
> > > > We've already recorded a corporate CLA with specific contributors and I
> > should
> > > > be in this list.
> > > 
> > > Ah, double-checked, I found you.
> > 
> > And, sorry about that, but, could you upload this CL from your @cisco.com
> email?
> > 
> NP, I think I uploaded this CL with my cisco address (I had to change my
> security gmail account which is bound with my Cisco address email to allow
it),
> I'll double check tomorrow morning.

It shows bedupontcisco@gmail.com for me.

[bedupontcisco_gmail.com, 2014-10-29 21:24:58]

On 2014/10/29 21:01:52, piman (Very slow to review) wrote:
> https://codereview.chromium.org/692543002/diff/20001/gpu/config/BUILD.gn
> File gpu/config/BUILD.gn (right):
> 
>
https://codereview.chromium.org/692543002/diff/20001/gpu/config/BUILD.gn#newc...
> gpu/config/BUILD.gn:65: if (is_linux && use_libpci && (use_x11 || use_ozone))
{
> I think you need to declare use_libpci in build/config/features.gni or
> something.
We don't use *.gn* file in our side (only *.gyp* files) thus I don't know
exactly what is needed to add a gn variable. BTW, tomorrow I'll check
"use_ozone" usages in *.gn* files, try to adapt it to use_libpci and upload a
new patch with, I hope, the good address email.

[bedupontcisco_gmail.com, 2014-10-29 21:46:42]

> > NP, I think I uploaded this CL with my cisco address (I had to change my
> > security gmail account which is bound with my Cisco address email to allow
> it),
> > I'll double check tomorrow morning.
> 
> It shows mailto:bedupontcisco@gmail.com for me.
Do you think I need to change anything in my gmail account settings (i.e.
"Migrate issues and repositories" with my Cisco email) or just delete cookies
from my previous CL upload and CL again with my Cisco email?

[piman, 2014-10-29 22:51:29]

On Wed, Oct 29, 2014 at 2:46 PM, <bedupontcisco@gmail.com> wrote:

> > NP, I think I uploaded this CL with my cisco address (I had to change my
>> > security gmail account which is bound with my Cisco address email to
>> allow
>> it),
>> > I'll double check tomorrow morning.
>>
>
>  It shows mailto:bedupontcisco@gmail.com for me.
>>
> Do you think I need to change anything in my gmail account settings (i.e.
> "Migrate issues and repositories" with my Cisco email) or just delete
> cookies
> from my previous CL upload and CL again with my Cisco email?
>

The latter, I think.


>
> https://codereview.chromium.org/692543002/
>

To unsubscribe from this group and stop receiving emails from it, send an email
to chromium-reviews+unsubscribe@chromium.org.

[bedupontcisco_gmail.com, 2014-10-30 09:22:38]

bedupontcisco@gmail.com changed reviewers:
+ brettw@chromium.org

[bedupontcisco_gmail.com, 2014-10-30 09:29:56]

On 2014/10/29 22:51:29, piman (Very slow to review) wrote:
> On Wed, Oct 29, 2014 at 2:46 PM, <mailto:bedupontcisco@gmail.com> wrote:
> 
> > > NP, I think I uploaded this CL with my cisco address (I had to change my
> >> > security gmail account which is bound with my Cisco address email to
> >> allow
> >> it),
> >> > I'll double check tomorrow morning.
> >>
> >
> >  It shows mailto:bedupontcisco@gmail.com for me.
> >>
> > Do you think I need to change anything in my gmail account settings (i.e.
> > "Migrate issues and repositories" with my Cisco email) or just delete
> > cookies
> > from my previous CL upload and CL again with my Cisco email?
> >
> 
> The latter, I think.
> 
> 
> >
> > https://codereview.chromium.org/692543002/
> >
> 
> To unsubscribe from this group and stop receiving emails from it, send an
email
> to mailto:chromium-reviews+unsubscribe@chromium.org.

I remove my cookie, CL upload again:
git cl upload --send-mail
Using 50% similarity for rename/copy detection. Override with --similarity.
Email (login for uploading to https://codereview.chromium.org)
[bedupont@cisco.com]: bedupont@cisco.com
Password for bedupont@cisco.com: 
Saving authentication cookies to /home/bdupont/.codereview_upload_cookies
Running presubmit upload checks ...

** Presubmit Messages **
Missing OWNER reviewers for these files:
    build/config/ui.gni

Suggested OWNERS: (Use "git-cl owners" to interactively select owners.)
    brettw@chromium.org

Presubmit checks passed.
 AUTHORS                                |   1 +
 build/common.gypi                      |   9 +++++++++
 build/config/ui.gni                    |   3 +++
 build/linux/system.gyp                 | 132
++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++----------------------------------------------------------------
 gpu/config/BUILD.gn                    |   5 ++++-
 gpu/config/gpu_info_collector_linux.cc |  10 +++++++++-
 gpu/gpu_config.gypi                    |   2 +-
 7 files changed, 95 insertions(+), 67 deletions(-)
This branch is associated with issue 692543002. Adding patch to that issue.
Upload server: https://codereview.chromium.org (change with -s/--server)
Loaded authentication cookies from /home/bdupont/.codereview_upload_cookies
Title describing this patch set: Add use_libpci definition into ui.gni (included
in gpu/config/BUILD.gn)
Issue updated. URL: https://codereview.chromium.org/692543002
Uploading base file for build/config/ui.gni

As you can see, normally bedupont@cisco.com email address was used for this CL.

I add the use_libpci definition into ui.gni because this is the one imported
into gpu/config/BUILD.gn.

[brettw, 2014-10-30 17:00:50]

https://codereview.chromium.org/692543002/diff/40001/build/config/ui.gni
File build/config/ui.gni (right):

https://codereview.chromium.org/692543002/diff/40001/build/config/ui.gni#newc...
build/config/ui.gni:23: # Use the PCI lib to collect GPU information.
Can this comment include whether this is Linux only? (I assume it is).

Is it possible to move this to the BUILD.gn file in GPU? In the GN build we
avoid globals, and basically all of the stuff in ui.gni and features.gni should
be moved out.

https://codereview.chromium.org/692543002/diff/40001/gpu/config/BUILD.gn
File gpu/config/BUILD.gn (right):

https://codereview.chromium.org/692543002/diff/40001/gpu/config/BUILD.gn#newc...
gpu/config/BUILD.gn:65: if(use_libpci) {
space before (

[Benjamin Dupont, 2014-10-31 10:19:13]

On 2014/10/30 17:00:50, brettw wrote:
> https://codereview.chromium.org/692543002/diff/40001/build/config/ui.gni
> File build/config/ui.gni (right):
> 
>
https://codereview.chromium.org/692543002/diff/40001/build/config/ui.gni#newc...
> build/config/ui.gni:23: # Use the PCI lib to collect GPU information.
> Can this comment include whether this is Linux only? (I assume it is).
> 
> Is it possible to move this to the BUILD.gn file in GPU? In the GN build we
> avoid globals, and basically all of the stuff in ui.gni and features.gni
should
> be moved out.
> 
> https://codereview.chromium.org/692543002/diff/40001/gpu/config/BUILD.gn
> File gpu/config/BUILD.gn (right):
> 
>
https://codereview.chromium.org/692543002/diff/40001/gpu/config/BUILD.gn#newc...
> gpu/config/BUILD.gn:65: if(use_libpci) {
> space before (
Done, I create a new CL with my Cisco account:
https://codereview.chromium.org/692893004