Provide a way to disable libpci dependency.

Provide a way to disable libpci dependency.

Add a new gyp variable: use_libpci (default value is 1).
Add a new define when use_libpci==1: USE_LIBPCI.
Don't call specific PCI code in gpu_info_collector_linux.cc if USE_LIBPCI isn't defined.

BUG=427401
R=piman@chromium.org

Committed: https://crrev.com/65ce5accb99908e292b9766c3da6cf54d6cc337f
Cr-Commit-Position: refs/heads/master@{#302613}

[Benjamin Dupont, 2014-10-31 10:20:14]

bedupont@cisco.com changed reviewers:
+ brettw@chromium.org, sievers@chromium.org

[Benjamin Dupont, 2014-10-31 10:22:23]

On 2014/10/31 10:17:42, Benjamin Dupont wrote:

Previous issue: https://codereview.chromium.org/692543002/

[piman, 2014-10-31 18:29:29]

https://codereview.chromium.org/692893004/diff/1/gpu/config/BUILD.gn
File gpu/config/BUILD.gn (right):

https://codereview.chromium.org/692893004/diff/1/gpu/config/BUILD.gn#newcode52
gpu/config/BUILD.gn:52: use_libpci = true
Should this be in a declare_args() block so that you can disable it at gn time?

[piman, 2014-10-31 18:29:29]

https://codereview.chromium.org/692893004/diff/1/gpu/config/BUILD.gn
File gpu/config/BUILD.gn (right):

https://codereview.chromium.org/692893004/diff/1/gpu/config/BUILD.gn#newcode52
gpu/config/BUILD.gn:52: use_libpci = true
Should this be in a declare_args() block so that you can disable it at gn time?

[brettw, 2014-10-31 19:20:06]

https://codereview.chromium.org/692893004/diff/1/gpu/config/BUILD.gn
File gpu/config/BUILD.gn (right):

https://codereview.chromium.org/692893004/diff/1/gpu/config/BUILD.gn#newcode52
gpu/config/BUILD.gn:52: use_libpci = true
On 2014/10/31 18:29:28, piman (Very slow to review) wrote:
> Should this be in a declare_args() block so that you can disable it at gn
time?

Yes, what you did here will always disable pci.

[Benjamin Dupont, 2014-11-03 09:03:06]

On 2014/10/31 19:20:06, brettw wrote:
> https://codereview.chromium.org/692893004/diff/1/gpu/config/BUILD.gn
> File gpu/config/BUILD.gn (right):
> 
> https://codereview.chromium.org/692893004/diff/1/gpu/config/BUILD.gn#newcode52
> gpu/config/BUILD.gn:52: use_libpci = true
> On 2014/10/31 18:29:28, piman (Very slow to review) wrote:
> > Should this be in a declare_args() block so that you can disable it at gn
> time?

Ok thank you, as I mentioned in a previous comment I don't know how *.gn* files
works.

> 
> Yes, what you did here will always disable pci.

Did you mean "always enable pci" or I've missed something?

[brettw, 2014-11-03 19:02:06]

*.gn LGTM

[piman, 2014-11-03 19:11:05]

lgtm

[Benjamin Dupont, 2014-11-04 12:00:04]

The CQ bit was checked by bedupont@cisco.com

[commit-bot: I haz the power, 2014-11-04 12:01:34]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/692893004/20001

[commit-bot: I haz the power, 2014-11-04 16:30:50]

Committed patchset #2 (id:20001)

[commit-bot: I haz the power, 2014-11-04 16:31:30]

Patchset 2 (id:??) landed as
https://crrev.com/65ce5accb99908e292b9766c3da6cf54d6cc337f
Cr-Commit-Position: refs/heads/master@{#302613}