Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(187)

Issue 692443002: Move the v8::Isolate* parameter to the first parameter of various binding methods in third_party/We… (Closed)

Created:
6 years, 1 month ago by RAGHURAM
Modified:
6 years, 1 month ago
Reviewers:
haraken
CC:
blink-reviews, michaeln, jsbell+serviceworker_chromium.org, arv+blink, tzik, serviceworker-reviews, nhiroki, falken, blink-reviews-bindings_chromium.org, horo+watch_chromium.org, kinuko+serviceworker
Base URL:
https://chromium.googlesource.com/chromium/blink.git@master
Project:
blink
Visibility:
Public.

Description

Move the v8::Isolate* parameter to the first parameter of various binding methods in third_party/WebKit/Source/bindings This step is to move the v8::Isolate* parameter to the first parameter of various binding methods in third_party/WebKit/Source/bindings (Ref: binding-methods changed: static v8::Handle<v8::Value> createTypeError(const String&, v8::Isolate*) static v8::Handle<v8::Value> createRangeError(const String&, v8::Isolate*) static v8::Handle<v8::Value> throwRangeError(const String&, v8::Isolate*)) BUG=424446 Committed: https://src.chromium.org/viewvc/blink?view=rev&revision=184624

Patch Set 1 #

Patch Set 2 : #

Unified diffs Side-by-side diffs Delta from patch set Stats (+31 lines, -31 lines) Patch
M Source/bindings/core/v8/ExceptionState.cpp View 2 chunks +2 lines, -2 lines 0 comments Download
M Source/bindings/core/v8/V8Binding.cpp View 1 chunk +2 lines, -2 lines 0 comments Download
M Source/bindings/core/v8/V8ScriptRunner.cpp View 1 1 chunk +1 line, -1 line 0 comments Download
M Source/bindings/core/v8/V8ThrowException.h View 1 1 chunk +3 lines, -3 lines 0 comments Download
M Source/bindings/core/v8/V8ThrowException.cpp View 1 2 chunks +7 lines, -7 lines 0 comments Download
M Source/bindings/templates/methods.cpp View 1 chunk +1 line, -1 line 0 comments Download
M Source/bindings/tests/results/core/V8TestInterface.cpp View 1 1 chunk +1 line, -1 line 0 comments Download
M Source/bindings/tests/results/core/V8TestObject.cpp View 1 chunk +1 line, -1 line 0 comments Download
M Source/bindings/tests/results/modules/V8TestInterfacePartial.cpp View 1 chunk +1 line, -1 line 0 comments Download
M Source/modules/serviceworkers/Body.cpp View 1 chunk +1 line, -1 line 0 comments Download
M Source/modules/serviceworkers/Cache.cpp View 1 chunk +2 lines, -2 lines 0 comments Download
M Source/modules/serviceworkers/FetchManager.cpp View 1 chunk +1 line, -1 line 0 comments Download
M Source/modules/serviceworkers/ServiceWorkerGlobalScope.cpp View 8 chunks +8 lines, -8 lines 0 comments Download

Messages

Total messages: 18 (8 generated)
RAGHURAM
Please Review. Thanks & Regards
6 years, 1 month ago (2014-10-29 07:25:41 UTC) #2
haraken
LGTM
6 years, 1 month ago (2014-10-29 07:30:39 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/692443002/1
6 years, 1 month ago (2014-10-29 07:41:12 UTC) #5
commit-bot: I haz the power
Try jobs failed on following builders: win_blink_rel on tryserver.blink (http://build.chromium.org/p/tryserver.blink/builders/win_blink_rel/builds/34111)
6 years, 1 month ago (2014-10-29 08:57:25 UTC) #7
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/692443002/1
6 years, 1 month ago (2014-10-29 11:16:23 UTC) #9
commit-bot: I haz the power
Failed to apply patch for Source/bindings/core/v8/V8ThrowException.h: While running patch -p1 --forward --force --no-backup-if-mismatch; patching file ...
6 years, 1 month ago (2014-10-29 11:16:34 UTC) #11
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/692443002/1
6 years, 1 month ago (2014-10-29 11:41:37 UTC) #13
commit-bot: I haz the power
Failed to apply patch for Source/bindings/core/v8/V8ThrowException.h: While running patch -p1 --forward --force --no-backup-if-mismatch; patching file ...
6 years, 1 month ago (2014-10-29 11:41:47 UTC) #15
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/692443002/20001
6 years, 1 month ago (2014-10-30 06:33:09 UTC) #17
commit-bot: I haz the power
6 years, 1 month ago (2014-10-30 07:47:30 UTC) #18
Message was sent while issue was closed.
Committed patchset #2 (id:20001) as 184624

Powered by Google App Engine
This is Rietveld 408576698