Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(162)

Unified Diff: Source/bindings/core/v8/ExceptionState.cpp

Issue 692443002: Move the v8::Isolate* parameter to the first parameter of various binding methods in third_party/We… (Closed) Base URL: https://chromium.googlesource.com/chromium/blink.git@master
Patch Set: Created 6 years, 2 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « no previous file | Source/bindings/core/v8/V8Binding.cpp » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: Source/bindings/core/v8/ExceptionState.cpp
diff --git a/Source/bindings/core/v8/ExceptionState.cpp b/Source/bindings/core/v8/ExceptionState.cpp
index f54d7a15b70304faaa317a651a94eedb770fe200..775ea8779e23799630d2209d73c44678d341e01a 100644
--- a/Source/bindings/core/v8/ExceptionState.cpp
+++ b/Source/bindings/core/v8/ExceptionState.cpp
@@ -99,7 +99,7 @@ void ExceptionState::throwTypeError(const String& message)
ASSERT(m_isolate);
m_code = V8TypeError;
m_message = message;
- setException(V8ThrowException::createTypeError(addExceptionContext(message), m_isolate));
+ setException(V8ThrowException::createTypeError(m_isolate, addExceptionContext(message)));
}
void ExceptionState::throwRangeError(const String& message)
@@ -107,7 +107,7 @@ void ExceptionState::throwRangeError(const String& message)
ASSERT(m_isolate);
m_code = V8RangeError;
m_message = message;
- setException(V8ThrowException::createRangeError(addExceptionContext(message), m_isolate));
+ setException(V8ThrowException::createRangeError(m_isolate, addExceptionContext(message)));
}
void NonThrowableExceptionState::throwDOMException(const ExceptionCode& ec, const String& message)
« no previous file with comments | « no previous file | Source/bindings/core/v8/V8Binding.cpp » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698