Source/bindings/core/v8/V8ScriptRunner.cpp - Issue 692443002: Move the v8::Isolate* parameter to the first parameter of various binding methods in third_party/We…

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: Source/bindings/core/v8/V8ScriptRunner.cpp

Issue 692443002: Move the v8::Isolate* parameter to the first parameter of various binding methods in third_party/We… (Closed) Base URL: https://chromium.googlesource.com/chromium/blink.git@master

Patch Set: Created 6 years, 2 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

Index: Source/bindings/core/v8/V8ScriptRunner.cpp

diff --git a/Source/bindings/core/v8/V8ScriptRunner.cpp b/Source/bindings/core/v8/V8ScriptRunner.cpp

index 752e965a03b9dc4b9ab4e5f366185510886f40c9..15b10862e4b9ddfbbf9597df1bd3834530f99449 100644

--- a/Source/bindings/core/v8/V8ScriptRunner.cpp

+++ b/Source/bindings/core/v8/V8ScriptRunner.cpp

@@ -48,7 +48,7 @@ namespace {

// throwStackOverflowException and call it.

void throwStackOverflowException(const v8::FunctionCallbackInfo<v8::Value>& info)

{

- V8ThrowException::throwRangeError("Maximum call stack size exceeded.", info.GetIsolate());

+ V8ThrowException::throwRangeError(info.GetIsolate(), "Maximum call stack size exceeded.");

}

v8::Local<v8::Value> throwStackOverflowExceptionIfNeeded(v8::Isolate* isolate)

« no previous file with comments | « Source/bindings/core/v8/V8Binding.cpp ('k') | Source/bindings/core/v8/V8ThrowException.h » ('j') | no next file with comments »