Use --no-output-all-resource-defines for grit on iOS.

Use --no-output-all-resource-defines for grit on iOS.

Passing this flag to grit will prevent it from including all
resource IDs in header files and resource maps. The default
behavior is to output all resource defines, even for whitelisted
elements, so this will force compile errors if iOS depends on
resource IDs that are not whitelisted.

BUG=428947, 425998
Committed: https://crrev.com/59d7c372f9091d7b6b6c62789148121301336d6c
Cr-Commit-Position: refs/heads/master@{#303242}

[lliabraa, 2014-11-05 17:57:49]

lliabraa@chromium.org changed reviewers:
+ rohitrao@chromium.org

[lliabraa, 2014-11-05 17:57:49]

@rohtrao for iOS review
@newt FYI

[lliabraa, 2014-11-05 17:59:06]

lliabraa@chromium.org changed reviewers:
+ estade@chromium.org

[lliabraa, 2014-11-05 17:59:07]

+estade for components/autofill OWNERS

[Evan Stade, 2014-11-05 23:26:37]

estade@chromium.org changed reviewers:
+ dconnelly@chromium.org

[Evan Stade, 2014-11-05 23:26:38]

+dconnelly

doesn't ios show an icon in the keyboard accessory view? where does that come
from?

[dconnelly, 2014-11-06 11:21:38]

On 2014/11/05 23:26:38, Evan Stade wrote:
> +dconnelly
> 
> doesn't ios show an icon in the keyboard accessory view? where does that come
> from?

It does, but they're all duplicated:

- The icon files themselves are duplicated in
ios_internal/chrome/browser/web/resources/autofill_card_*.
- The resources are redefined in
ios/public/consumer/components/autofill/autofill_constants.h and
ios/consumer/components/autofill/autofill_constants.mm.
- The card type to icon mapping is defined in
ios_internal/chrome/browser/autofill/form_suggestion_label.mm

I don't know why Jim opted to redefine/duplicate these. I patched this in and
tested in the simulator and the credit card icons are still shown in the
accessory view, so I'm pretty sure that this won't break anything.

Lane: thanks for doing this. Do you want to add BUG=425998, too?

[lliabraa, 2014-11-06 13:10:13]

On 2014/11/06 11:21:38, dconnelly wrote:
> On 2014/11/05 23:26:38, Evan Stade wrote:
> > +dconnelly
> > 
> > doesn't ios show an icon in the keyboard accessory view? where does that
come
> > from?
> 
> It does, but they're all duplicated:
> 
> - The icon files themselves are duplicated in
> ios_internal/chrome/browser/web/resources/autofill_card_*.
> - The resources are redefined in
> ios/public/consumer/components/autofill/autofill_constants.h and
> ios/consumer/components/autofill/autofill_constants.mm.
> - The card type to icon mapping is defined in
> ios_internal/chrome/browser/autofill/form_suggestion_label.mm
> 
> I don't know why Jim opted to redefine/duplicate these. I patched this in and
> tested in the simulator and the credit card icons are still shown in the
> accessory view, so I'm pretty sure that this won't break anything.

Thanks for double checking. I imagine the reason for duplication is because iOS
uses a slightly different size of icon. FWIW, I think the iOS code should be
refactored to load the assets from a .pak file (i.e. ResourceBundle not
imageNamed) and just specify the different-sized assets in an if expr="is_ios"
block in the .grd. That would avoid a fair amount of confusion.

> 
> Lane: thanks for doing this. Do you want to add BUG=425998, too?

Done.

[Evan Stade, 2014-11-07 02:26:50]

lgtm

[rohitrao (ping after 24h), 2014-11-07 14:17:25]

lgtm

[lliabraa, 2014-11-07 15:21:55]

The CQ bit was checked by lliabraa@chromium.org

[commit-bot: I haz the power, 2014-11-07 15:22:47]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/692233002/220001

[commit-bot: I haz the power, 2014-11-07 16:28:41]

Committed patchset #12 (id:220001)

[commit-bot: I haz the power, 2014-11-07 16:29:57]

Patchset 12 (id:??) landed as
https://crrev.com/59d7c372f9091d7b6b6c62789148121301336d6c
Cr-Commit-Position: refs/heads/master@{#303242}