components/autofill/core/browser/credit_card.h - Issue 692233002: Use --no-output-all-resource-defines for grit on iOS.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: components/autofill/core/browser/credit_card.h

Issue 692233002: Use --no-output-all-resource-defines for grit on iOS. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: readd a couple last resource IDs Created 6 years, 1 month ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

Index: components/autofill/core/browser/credit_card.h

diff --git a/components/autofill/core/browser/credit_card.h b/components/autofill/core/browser/credit_card.h

index 1651d3eab806f050a6276ce53a43546e316bbfae..c498af65cf43ad609ab27a10b4c508cd8eae5cca 100644

--- a/components/autofill/core/browser/credit_card.h

+++ b/components/autofill/core/browser/credit_card.h

@@ -31,8 +31,12 @@ class CreditCard : public AutofillDataModel {

// The user-visible type of the card, e.g. 'Mastercard'.

static base::string16 TypeForDisplay(const std::string& type);

+// This method is not compiled on iOS because the resources are not used and

+// should not be shipped.

+#if !defined(OS_IOS)

// The ResourceBundle ID for the appropriate credit card image.

static int IconResourceId(const std::string& type);

+#endif // #if !defined(OS_IOS)

// Returns the internal representation of credit card type corresponding to

// the given |number|. The credit card type is determined purely according to

« no previous file with comments | « build/ios/grit_whitelist.txt ('k') | components/autofill/core/browser/credit_card.cc » ('j') | no next file with comments »