Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(68)

Side by Side Diff: components/autofill/core/browser/credit_card_unittest.cc

Issue 692233002: Use --no-output-all-resource-defines for grit on iOS. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: readd a couple last resource IDs Created 6 years, 1 month ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch
« no previous file with comments | « components/autofill/core/browser/credit_card.cc ('k') | no next file » | no next file with comments »
Toggle Intra-line Diffs ('i') | Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
OLDNEW
1 // Copyright 2013 The Chromium Authors. All rights reserved. 1 // Copyright 2013 The Chromium Authors. All rights reserved.
2 // Use of this source code is governed by a BSD-style license that can be 2 // Use of this source code is governed by a BSD-style license that can be
3 // found in the LICENSE file. 3 // found in the LICENSE file.
4 4
5 #include "base/basictypes.h" 5 #include "base/basictypes.h"
6 #include "base/guid.h" 6 #include "base/guid.h"
7 #include "base/strings/utf_string_conversions.h" 7 #include "base/strings/utf_string_conversions.h"
8 #include "components/autofill/core/browser/autofill_test_utils.h" 8 #include "components/autofill/core/browser/autofill_test_utils.h"
9 #include "components/autofill/core/browser/autofill_type.h" 9 #include "components/autofill/core/browser/autofill_type.h"
10 #include "components/autofill/core/browser/credit_card.h" 10 #include "components/autofill/core/browser/credit_card.h"
(...skipping 145 matching lines...) Expand 10 before | Expand all | Expand 10 after
156 b.set_origin("banana"); 156 b.set_origin("banana");
157 EXPECT_EQ(0, a.Compare(b)); 157 EXPECT_EQ(0, a.Compare(b));
158 158
159 // Different values produce non-zero results. 159 // Different values produce non-zero results.
160 test::SetCreditCardInfo(&a, "Jimmy", NULL, NULL, NULL); 160 test::SetCreditCardInfo(&a, "Jimmy", NULL, NULL, NULL);
161 test::SetCreditCardInfo(&b, "Ringo", NULL, NULL, NULL); 161 test::SetCreditCardInfo(&b, "Ringo", NULL, NULL, NULL);
162 EXPECT_GT(0, a.Compare(b)); 162 EXPECT_GT(0, a.Compare(b));
163 EXPECT_LT(0, b.Compare(a)); 163 EXPECT_LT(0, b.Compare(a));
164 } 164 }
165 165
166 // This method is not compiled for iOS because these resources are not used and
167 // should not be shipped.
168 #if !defined(OS_IOS)
166 // Test we get the correct icon for each card type. 169 // Test we get the correct icon for each card type.
167 TEST(CreditCardTest, IconResourceId) { 170 TEST(CreditCardTest, IconResourceId) {
168 EXPECT_EQ(IDR_AUTOFILL_CC_AMEX, 171 EXPECT_EQ(IDR_AUTOFILL_CC_AMEX,
169 CreditCard::IconResourceId(kAmericanExpressCard)); 172 CreditCard::IconResourceId(kAmericanExpressCard));
170 EXPECT_EQ(IDR_AUTOFILL_CC_DINERS, 173 EXPECT_EQ(IDR_AUTOFILL_CC_DINERS,
171 CreditCard::IconResourceId(kDinersCard)); 174 CreditCard::IconResourceId(kDinersCard));
172 EXPECT_EQ(IDR_AUTOFILL_CC_DISCOVER, 175 EXPECT_EQ(IDR_AUTOFILL_CC_DISCOVER,
173 CreditCard::IconResourceId(kDiscoverCard)); 176 CreditCard::IconResourceId(kDiscoverCard));
174 EXPECT_EQ(IDR_AUTOFILL_CC_JCB, 177 EXPECT_EQ(IDR_AUTOFILL_CC_JCB,
175 CreditCard::IconResourceId(kJCBCard)); 178 CreditCard::IconResourceId(kJCBCard));
176 EXPECT_EQ(IDR_AUTOFILL_CC_MASTERCARD, 179 EXPECT_EQ(IDR_AUTOFILL_CC_MASTERCARD,
177 CreditCard::IconResourceId(kMasterCard)); 180 CreditCard::IconResourceId(kMasterCard));
178 EXPECT_EQ(IDR_AUTOFILL_CC_VISA, 181 EXPECT_EQ(IDR_AUTOFILL_CC_VISA,
179 CreditCard::IconResourceId(kVisaCard)); 182 CreditCard::IconResourceId(kVisaCard));
180 } 183 }
184 #endif // #if !defined(OS_IOS)
181 185
182 TEST(CreditCardTest, UpdateFromImportedCard) { 186 TEST(CreditCardTest, UpdateFromImportedCard) {
183 CreditCard original_card(base::GenerateGUID(), "https://www.example.com"); 187 CreditCard original_card(base::GenerateGUID(), "https://www.example.com");
184 test::SetCreditCardInfo( 188 test::SetCreditCardInfo(
185 &original_card, "John Dillinger", "123456789012", "09", "2017"); 189 &original_card, "John Dillinger", "123456789012", "09", "2017");
186 190
187 CreditCard a = original_card; 191 CreditCard a = original_card;
188 192
189 // The new card has a different name, expiration date, and origin. 193 // The new card has a different name, expiration date, and origin.
190 CreditCard b = a; 194 CreditCard b = a;
(...skipping 329 matching lines...) Expand 10 before | Expand all | Expand 10 after
520 524
521 for (size_t i = 0; i < arraysize(test_cases); ++i) { 525 for (size_t i = 0; i < arraysize(test_cases); ++i) {
522 base::string16 card_number = ASCIIToUTF16(test_cases[i].card_number); 526 base::string16 card_number = ASCIIToUTF16(test_cases[i].card_number);
523 SCOPED_TRACE(card_number); 527 SCOPED_TRACE(card_number);
524 EXPECT_EQ(test_cases[i].type, CreditCard::GetCreditCardType(card_number)); 528 EXPECT_EQ(test_cases[i].type, CreditCard::GetCreditCardType(card_number));
525 EXPECT_EQ(test_cases[i].is_valid, IsValidCreditCardNumber(card_number)); 529 EXPECT_EQ(test_cases[i].is_valid, IsValidCreditCardNumber(card_number));
526 } 530 }
527 } 531 }
528 532
529 } // namespace autofill 533 } // namespace autofill
OLDNEW
« no previous file with comments | « components/autofill/core/browser/credit_card.cc ('k') | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698