ServiceWorker: Registering a malformed script should fail [1/3]

Source/core/workers/WorkerReportingProxy.h

Index: Source/core/workers/WorkerReportingProxy.h
diff --git a/Source/core/workers/WorkerReportingProxy.h b/Source/core/workers/WorkerReportingProxy.h
index b6a6f723548a736ab7d29a202f5d1186ec404982..360464f067629c09fe5a76e0e7c69707d2d31eed 100644
--- a/Source/core/workers/WorkerReportingProxy.h
+++ b/Source/core/workers/WorkerReportingProxy.h
@@ -40,7 +40,7 @@ namespace blink {
 class ConsoleMessage;
 class WorkerGlobalScope;
 
-// APIs used by workers to report console activity.
+// APIs used by workers to report console and worker activity.
 class WorkerReportingProxy {
 public:
     virtual ~WorkerReportingProxy() { }
@@ -49,6 +49,10 @@ public:
     virtual void reportConsoleMessage(PassRefPtrWillBeRawPtr<ConsoleMessage>) = 0;
     virtual void postMessageToPageInspector(const String&) = 0;
 
+    // Invoked when the worker script is evaluated. |success| is true if the
+    // evaluation completed with no uncaught exception.
+    virtual void workerScriptEvaluated(bool success) = 0;

[tkent, 2014/11/05 02:10:22]

Please name this as |didEvaluateWorkerScript|.  |will| and |did| are common
prefixes for notification receiver functions in Blink.

We usually avoid bool arguments, however the bool argument of this function is
acceptable in this case because literal |true| or |false| won't appear in the
source code.

[nhiroki, 2014/11/05 03:09:48]

Done.

+
     // Invoked when the new WorkerGlobalScope is started.
     virtual void workerGlobalScopeStarted(WorkerGlobalScope*) = 0;