Source/core/workers/WorkerObjectProxy.h - Issue 692003002: ServiceWorker: Registering a malformed script should fail [1/3]

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: Source/core/workers/WorkerObjectProxy.h

Issue 692003002: ServiceWorker: Registering a malformed script should fail [1/3] (Closed) Base URL: https://chromium.googlesource.com/chromium/blink.git@master

Patch Set: address falken@'s comments Created 6 years, 1 month ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « Source/bindings/core/v8/WorkerScriptController.cpp ('k') | Source/core/workers/WorkerReportingProxy.h » ('j') | Source/core/workers/WorkerReportingProxy.h » ('J')
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: Source/core/workers/WorkerObjectProxy.h

diff --git a/Source/core/workers/WorkerObjectProxy.h b/Source/core/workers/WorkerObjectProxy.h

index 75902dd7b117c00d3701645e0a2b96ac1224ced0..f66ab9b8be979d69cce3beff41da9d0f103f931d 100644

--- a/Source/core/workers/WorkerObjectProxy.h

+++ b/Source/core/workers/WorkerObjectProxy.h

@@ -63,6 +63,7 @@ public:

virtual void reportException(const String& errorMessage, int lineNumber, int columnNumber, const String& sourceURL) override;

virtual void reportConsoleMessage(PassRefPtrWillBeRawPtr<ConsoleMessage>) override;

virtual void postMessageToPageInspector(const String&) override;

+ virtual void workerScriptEvaluated(bool success) override { };

virtual void workerGlobalScopeStarted(WorkerGlobalScope*) override { }

virtual void workerGlobalScopeClosed() override;

virtual void workerThreadTerminated() override;