Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1974)

Unified Diff: Source/core/workers/WorkerThread.cpp

Issue 692003002: ServiceWorker: Registering a malformed script should fail [1/3] (Closed) Base URL: https://chromium.googlesource.com/chromium/blink.git@master
Patch Set: address falken@'s comments Created 6 years, 1 month ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: Source/core/workers/WorkerThread.cpp
diff --git a/Source/core/workers/WorkerThread.cpp b/Source/core/workers/WorkerThread.cpp
index 4afc1f86c0dd84d85880c9f0ca1d31ee3f73c104..54e9dd0269e20d3e5f523ff1c0bc0234670c68c1 100644
--- a/Source/core/workers/WorkerThread.cpp
+++ b/Source/core/workers/WorkerThread.cpp
@@ -320,9 +320,12 @@ void WorkerThread::initialize()
if (!script->isExecutionForbidden())
script->initializeContextIfNeeded();
InspectorInstrumentation::willEvaluateWorkerScript(workerGlobalScope(), startMode);
- script->evaluate(ScriptSourceCode(sourceCode, scriptURL));
+ bool success = script->evaluate(ScriptSourceCode(sourceCode, scriptURL));
m_workerGlobalScope->didEvaluateWorkerScript();
+ // Notify proxy that a worker script has been evaluated.
tkent 2014/11/05 02:10:22 This comment is helpless. Please remove it.
nhiroki 2014/11/05 03:09:48 Done.
+ m_workerReportingProxy.workerScriptEvaluated(success);
+
postInitialize();
postDelayedTask(createSameThreadTask(&WorkerThread::idleHandler, this), kShortIdleHandlerDelayMs);

Powered by Google App Engine
This is Rietveld 408576698