Issue 691853002: minidump: Fix InitializeFromSnapshot() comments for module lists

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 691853002: minidump: Fix InitializeFromSnapshot() comments for module lists (Closed)

Created:
6 years, 1 month ago by Mark Mentovai

Modified:
6 years, 1 month ago

Reviewers:
Robert Sesek

CC:
crashpad-dev_chromium.org

Base URL:
https://chromium.googlesource.com/crashpad/crashpad@master

Project:
crashpad

Visibility:
Public.

minidump: Fix InitializeFromSnapshot() comments for module lists. These classes don’t really have “mutators” other than their singular AddModule() methods, and the documentation is clearer when revised in this way. R=rsesek@chromium.org Committed: https://chromium.googlesource.com/crashpad/crashpad/+/f7b38a9dd95c5162023f9b56762222d9f5586bbc

Created: 6 years, 1 month ago

Download [raw] [tar.bz2]

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+6 lines, -6 lines)			Patch
	M	minidump/minidump_module_crashpad_info_writer.h	View		1 chunk	+3 lines, -3 lines	0 comments	Download
	M	minidump/minidump_module_writer.h	View		1 chunk	+3 lines, -3 lines	0 comments	Download

Total messages: 4 (1 generated)

Robert Sesek

LGTM. Since AddModule is reported to only be valid in kStateMutable, calling it a mutator ...

6 years, 1 month ago (2014-10-30 18:49:12 UTC) #3

Mark Mentovai

6 years, 1 month ago (2014-10-30 18:51:46 UTC) #4

Message was sent while issue was closed.

Committed patchset #1 (id:1) manually as
f7b38a9dd95c5162023f9b56762222d9f5586bbc (presubmit successful).