Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(101)

Side by Side Diff: minidump/minidump_module_writer.h

Issue 691853002: minidump: Fix InitializeFromSnapshot() comments for module lists (Closed) Base URL: https://chromium.googlesource.com/crashpad/crashpad@master
Patch Set: Created 6 years, 1 month ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch
« no previous file with comments | « minidump/minidump_module_crashpad_info_writer.h ('k') | no next file » | no next file with comments »
Toggle Intra-line Diffs ('i') | Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
OLDNEW
1 // Copyright 2014 The Crashpad Authors. All rights reserved. 1 // Copyright 2014 The Crashpad Authors. All rights reserved.
2 // 2 //
3 // Licensed under the Apache License, Version 2.0 (the "License"); 3 // Licensed under the Apache License, Version 2.0 (the "License");
4 // you may not use this file except in compliance with the License. 4 // you may not use this file except in compliance with the License.
5 // You may obtain a copy of the License at 5 // You may obtain a copy of the License at
6 // 6 //
7 // http://www.apache.org/licenses/LICENSE-2.0 7 // http://www.apache.org/licenses/LICENSE-2.0
8 // 8 //
9 // Unless required by applicable law or agreed to in writing, software 9 // Unless required by applicable law or agreed to in writing, software
10 // distributed under the License is distributed on an "AS IS" BASIS, 10 // distributed under the License is distributed on an "AS IS" BASIS,
(...skipping 302 matching lines...) Expand 10 before | Expand all | Expand 10 after
313 class MinidumpModuleListWriter final : public internal::MinidumpStreamWriter { 313 class MinidumpModuleListWriter final : public internal::MinidumpStreamWriter {
314 public: 314 public:
315 MinidumpModuleListWriter(); 315 MinidumpModuleListWriter();
316 ~MinidumpModuleListWriter() override; 316 ~MinidumpModuleListWriter() override;
317 317
318 //! \brief Adds an initialized MINIDUMP_MODULE for each module in \a 318 //! \brief Adds an initialized MINIDUMP_MODULE for each module in \a
319 //! module_snapshots to the MINIDUMP_MODULE_LIST. 319 //! module_snapshots to the MINIDUMP_MODULE_LIST.
320 //! 320 //!
321 //! \param[in] module_snapshots The module snapshots to use as source data. 321 //! \param[in] module_snapshots The module snapshots to use as source data.
322 //! 322 //!
323 //! \note Valid in #kStateMutable. No mutator methods may be called before 323 //! \note Valid in #kStateMutable. AddModule() may not be called before this
324 //! this method, and it is not normally necessary to call any mutator 324 //! this method, and it is not normally necessary to call AddModule()
325 //! methods after this method. 325 //! after this method.
326 void InitializeFromSnapshot( 326 void InitializeFromSnapshot(
327 const std::vector<const ModuleSnapshot*>& module_snapshots); 327 const std::vector<const ModuleSnapshot*>& module_snapshots);
328 328
329 //! \brief Adds a MinidumpModuleWriter to the MINIDUMP_MODULE_LIST. 329 //! \brief Adds a MinidumpModuleWriter to the MINIDUMP_MODULE_LIST.
330 //! 330 //!
331 //! This object takes ownership of \a module and becomes its parent in the 331 //! This object takes ownership of \a module and becomes its parent in the
332 //! overall tree of internal::MinidumpWritable objects. 332 //! overall tree of internal::MinidumpWritable objects.
333 //! 333 //!
334 //! \note Valid in #kStateMutable. 334 //! \note Valid in #kStateMutable.
335 void AddModule(scoped_ptr<MinidumpModuleWriter> module); 335 void AddModule(scoped_ptr<MinidumpModuleWriter> module);
(...skipping 11 matching lines...) Expand all
347 private: 347 private:
348 MINIDUMP_MODULE_LIST module_list_base_; 348 MINIDUMP_MODULE_LIST module_list_base_;
349 PointerVector<MinidumpModuleWriter> modules_; 349 PointerVector<MinidumpModuleWriter> modules_;
350 350
351 DISALLOW_COPY_AND_ASSIGN(MinidumpModuleListWriter); 351 DISALLOW_COPY_AND_ASSIGN(MinidumpModuleListWriter);
352 }; 352 };
353 353
354 } // namespace crashpad 354 } // namespace crashpad
355 355
356 #endif // CRASHPAD_MINIDUMP_MINIDUMP_MODULE_WRITER_H_ 356 #endif // CRASHPAD_MINIDUMP_MINIDUMP_MODULE_WRITER_H_
OLDNEW
« no previous file with comments | « minidump/minidump_module_crashpad_info_writer.h ('k') | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698