Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(195)

Side by Side Diff: minidump/minidump_module_crashpad_info_writer.h

Issue 691853002: minidump: Fix InitializeFromSnapshot() comments for module lists (Closed) Base URL: https://chromium.googlesource.com/crashpad/crashpad@master
Patch Set: Created 6 years, 1 month ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch
« no previous file with comments | « no previous file | minidump/minidump_module_writer.h » ('j') | no next file with comments »
Toggle Intra-line Diffs ('i') | Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
OLDNEW
1 // Copyright 2014 The Crashpad Authors. All rights reserved. 1 // Copyright 2014 The Crashpad Authors. All rights reserved.
2 // 2 //
3 // Licensed under the Apache License, Version 2.0 (the "License"); 3 // Licensed under the Apache License, Version 2.0 (the "License");
4 // you may not use this file except in compliance with the License. 4 // you may not use this file except in compliance with the License.
5 // You may obtain a copy of the License at 5 // You may obtain a copy of the License at
6 // 6 //
7 // http://www.apache.org/licenses/LICENSE-2.0 7 // http://www.apache.org/licenses/LICENSE-2.0
8 // 8 //
9 // Unless required by applicable law or agreed to in writing, software 9 // Unless required by applicable law or agreed to in writing, software
10 // distributed under the License is distributed on an "AS IS" BASIS, 10 // distributed under the License is distributed on an "AS IS" BASIS,
(...skipping 95 matching lines...) Expand 10 before | Expand all | Expand 10 after
106 106
107 //! \brief Adds an initialized MinidumpModuleCrashpadInfo for modules in \a 107 //! \brief Adds an initialized MinidumpModuleCrashpadInfo for modules in \a
108 //! module_snapshots to the MinidumpModuleCrashpadInfoList. 108 //! module_snapshots to the MinidumpModuleCrashpadInfoList.
109 //! 109 //!
110 //! Only modules in \a module_snapshots that would produce a useful 110 //! Only modules in \a module_snapshots that would produce a useful
111 //! MinidumpModuleCrashpadInfo structure are included. Usefulness is 111 //! MinidumpModuleCrashpadInfo structure are included. Usefulness is
112 //! determined by MinidumpModuleCrashpadInfoWriter::IsUseful(). 112 //! determined by MinidumpModuleCrashpadInfoWriter::IsUseful().
113 //! 113 //!
114 //! \param[in] module_snapshots The module snapshots to use as source data. 114 //! \param[in] module_snapshots The module snapshots to use as source data.
115 //! 115 //!
116 //! \note Valid in #kStateMutable. No mutator methods may be called before 116 //! \note Valid in #kStateMutable. AddModule() may not be called before this
117 //! this method, and it is not normally necessary to call any mutator 117 //! method, and it is not normally necessary to call AddModule() after
118 //! methods after this method. 118 //! this method.
119 void InitializeFromSnapshot( 119 void InitializeFromSnapshot(
120 const std::vector<const ModuleSnapshot*>& module_snapshots); 120 const std::vector<const ModuleSnapshot*>& module_snapshots);
121 121
122 //! \brief Adds a MinidumpModuleCrashpadInfo to the 122 //! \brief Adds a MinidumpModuleCrashpadInfo to the
123 //! MinidumpModuleCrashpadInfoList. 123 //! MinidumpModuleCrashpadInfoList.
124 //! 124 //!
125 //! This object takes ownership of \a module and becomes its parent in the 125 //! This object takes ownership of \a module and becomes its parent in the
126 //! overall tree of internal::MinidumpWritable objects. 126 //! overall tree of internal::MinidumpWritable objects.
127 //! 127 //!
128 //! \note Valid in #kStateMutable. 128 //! \note Valid in #kStateMutable.
(...skipping 10 matching lines...) Expand all
139 MinidumpModuleCrashpadInfoList module_list_base_; 139 MinidumpModuleCrashpadInfoList module_list_base_;
140 PointerVector<MinidumpModuleCrashpadInfoWriter> modules_; 140 PointerVector<MinidumpModuleCrashpadInfoWriter> modules_;
141 std::vector<MINIDUMP_LOCATION_DESCRIPTOR> module_location_descriptors_; 141 std::vector<MINIDUMP_LOCATION_DESCRIPTOR> module_location_descriptors_;
142 142
143 DISALLOW_COPY_AND_ASSIGN(MinidumpModuleCrashpadInfoListWriter); 143 DISALLOW_COPY_AND_ASSIGN(MinidumpModuleCrashpadInfoListWriter);
144 }; 144 };
145 145
146 } // namespace crashpad 146 } // namespace crashpad
147 147
148 #endif // CRASHPAD_MINIDUMP_MINIDUMP_MODULE_CRASHPAD_INFO_WRITER_H_ 148 #endif // CRASHPAD_MINIDUMP_MINIDUMP_MODULE_CRASHPAD_INFO_WRITER_H_
OLDNEW
« no previous file with comments | « no previous file | minidump/minidump_module_writer.h » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698