Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(152)

Issue 691513002: [turbofan] Introduce new Select operator to improve bounds checking. (Closed)

Created:
6 years, 1 month ago by Benedikt Meurer
Modified:
6 years, 1 month ago
Reviewers:
dcarney
CC:
v8-dev
Project:
v8
Visibility:
Public.

Description

[turbofan] Introduce new Select operator to improve bounds checking. TEST=mjsunit,unittests R=dcarney@chromium.org Committed: https://code.google.com/p/v8/source/detail?r=24980

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+460 lines, -81 lines) Patch
M src/compiler/common-operator.h View 2 chunks +25 lines, -0 lines 0 comments Download
M src/compiler/common-operator.cc View 2 chunks +34 lines, -0 lines 0 comments Download
M src/compiler/control-reducer.cc View 3 chunks +31 lines, -0 lines 0 comments Download
M src/compiler/js-generic-lowering.cc View 2 chunks +18 lines, -0 lines 0 comments Download
M src/compiler/js-typed-lowering.cc View 2 chunks +2 lines, -2 lines 0 comments Download
M src/compiler/machine-type.h View 1 chunk +2 lines, -0 lines 0 comments Download
M src/compiler/node-matchers.h View 2 chunks +9 lines, -0 lines 0 comments Download
M src/compiler/opcodes.h View 1 chunk +1 line, -0 lines 0 comments Download
M src/compiler/simplified-lowering.h View 1 chunk +1 line, -1 line 0 comments Download
M src/compiler/simplified-lowering.cc View 6 chunks +211 lines, -63 lines 0 comments Download
M src/compiler/typer.cc View 1 chunk +5 lines, -0 lines 0 comments Download
M src/compiler/verifier.cc View 1 chunk +6 lines, -0 lines 0 comments Download
M test/mjsunit/asm/int16array-outofbounds.js View 1 chunk +13 lines, -1 line 0 comments Download
M test/unittests/compiler/common-operator-unittest.cc View 2 chunks +29 lines, -2 lines 0 comments Download
M test/unittests/compiler/js-typed-lowering-unittest.cc View 4 chunks +11 lines, -12 lines 0 comments Download
M test/unittests/compiler/node-test-utils.h View 2 chunks +6 lines, -0 lines 0 comments Download
M test/unittests/compiler/node-test-utils.cc View 3 chunks +56 lines, -0 lines 0 comments Download

Messages

Total messages: 5 (1 generated)
Benedikt Meurer
PTAL
6 years, 1 month ago (2014-10-29 14:04:14 UTC) #2
Benedikt Meurer
Note: It's still not 64-bit clean, i.e. store/load indices are probably broken. Have to fix ...
6 years, 1 month ago (2014-10-29 14:04:42 UTC) #3
dcarney
lgtm
6 years, 1 month ago (2014-10-29 14:15:17 UTC) #4
Benedikt Meurer
6 years, 1 month ago (2014-10-29 14:16:54 UTC) #5
Message was sent while issue was closed.
Committed patchset #1 (id:1) manually as 24980 (tree was closed).

Powered by Google App Engine
This is Rietveld 408576698