src/compiler/js-typed-lowering.cc - Issue 691513002: [turbofan] Introduce new Select operator to improve bounds checking.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: src/compiler/js-typed-lowering.cc

Issue 691513002: [turbofan] Introduce new Select operator to improve bounds checking. (Closed) Base URL: https://v8.googlecode.com/svn/branches/bleeding_edge

Patch Set: Created 6 years, 2 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

Index: src/compiler/js-typed-lowering.cc

diff --git a/src/compiler/js-typed-lowering.cc b/src/compiler/js-typed-lowering.cc

index e4d25bb78a657ef987eaabc4a1dd5712fb8171c0..535e585f40413e0d98b45c4916c1190715eb3364 100644

--- a/src/compiler/js-typed-lowering.cc

+++ b/src/compiler/js-typed-lowering.cc

@@ -612,7 +612,7 @@ Reduction JSTypedLowering::ReduceJSLoadProperty(Node* node) {

Handle<ExternalArray>::cast(handle(array->elements()));

Node* pointer = jsgraph()->IntPtrConstant(

bit_cast<intptr_t>(elements->external_pointer()));

- Node* length = jsgraph()->Constant(byte_length / array->element_size());

+ Node* length = jsgraph()->Constant(array->length()->Number());

Node* effect = NodeProperties::GetEffectInput(node);

Node* load = graph()->NewNode(

simplified()->LoadElement(

@@ -647,7 +647,7 @@ Reduction JSTypedLowering::ReduceJSStoreProperty(Node* node) {

Handle<ExternalArray>::cast(handle(array->elements()));

Node* pointer = jsgraph()->IntPtrConstant(

bit_cast<intptr_t>(elements->external_pointer()));

- Node* length = jsgraph()->Constant(byte_length / array->element_size());

+ Node* length = jsgraph()->Constant(array->length()->Number());

Node* effect = NodeProperties::GetEffectInput(node);

Node* control = NodeProperties::GetControlInput(node);

Node* store = graph()->NewNode(

« no previous file with comments | « src/compiler/js-generic-lowering.cc ('k') | src/compiler/machine-type.h » ('j') | no next file with comments »