content/browser/service_worker/service_worker_info.cc - Issue 691413002: Removing redundant 'is_null' field in ServiceWorkerVersionInfo

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: content/browser/service_worker/service_worker_info.cc

Issue 691413002: Removing redundant 'is_null' field in ServiceWorkerVersionInfo (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: Created 6 years, 2 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « content/browser/service_worker/service_worker_info.h ('k') | content/browser/service_worker/service_worker_internals_ui.cc » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: content/browser/service_worker/service_worker_info.cc

diff --git a/content/browser/service_worker/service_worker_info.cc b/content/browser/service_worker/service_worker_info.cc

index d1ef56ec8a4a1ea257d94d3e0aec2021ad8ad07a..49f77c6e7c0f051d5bf7d2b4ce22f54e6fff879a 100644

--- a/content/browser/service_worker/service_worker_info.cc

+++ b/content/browser/service_worker/service_worker_info.cc

@@ -10,8 +10,7 @@

namespace content {

ServiceWorkerVersionInfo::ServiceWorkerVersionInfo()

- : is_null(true),

- running_status(ServiceWorkerVersion::STOPPED),

+ : running_status(ServiceWorkerVersion::STOPPED),

status(ServiceWorkerVersion::NEW),

version_id(kInvalidServiceWorkerVersionId),

process_id(-1),

@@ -27,8 +26,7 @@ ServiceWorkerVersionInfo::ServiceWorkerVersionInfo(

int process_id,

int thread_id,

int devtools_agent_route_id)

- : is_null(false),

- running_status(running_status),

+ : running_status(running_status),

status(status),

script_url(script_url),

version_id(version_id),