Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(56)

Side by Side Diff: content/browser/service_worker/service_worker_info.cc

Issue 691413002: Removing redundant 'is_null' field in ServiceWorkerVersionInfo (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Created 6 years, 1 month ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch
OLDNEW
1 // Copyright 2014 The Chromium Authors. All rights reserved. 1 // Copyright 2014 The Chromium Authors. All rights reserved.
2 // Use of this source code is governed by a BSD-style license that can be 2 // Use of this source code is governed by a BSD-style license that can be
3 // found in the LICENSE file. 3 // found in the LICENSE file.
4 4
5 #include "content/browser/service_worker/service_worker_info.h" 5 #include "content/browser/service_worker/service_worker_info.h"
6 6
7 #include "content/common/service_worker/service_worker_types.h" 7 #include "content/common/service_worker/service_worker_types.h"
8 #include "ipc/ipc_message.h" 8 #include "ipc/ipc_message.h"
9 9
10 namespace content { 10 namespace content {
11 11
12 ServiceWorkerVersionInfo::ServiceWorkerVersionInfo() 12 ServiceWorkerVersionInfo::ServiceWorkerVersionInfo()
13 : is_null(true), 13 : running_status(ServiceWorkerVersion::STOPPED),
14 running_status(ServiceWorkerVersion::STOPPED),
15 status(ServiceWorkerVersion::NEW), 14 status(ServiceWorkerVersion::NEW),
16 version_id(kInvalidServiceWorkerVersionId), 15 version_id(kInvalidServiceWorkerVersionId),
17 process_id(-1), 16 process_id(-1),
18 thread_id(-1), 17 thread_id(-1),
19 devtools_agent_route_id(MSG_ROUTING_NONE) { 18 devtools_agent_route_id(MSG_ROUTING_NONE) {
20 } 19 }
21 20
22 ServiceWorkerVersionInfo::ServiceWorkerVersionInfo( 21 ServiceWorkerVersionInfo::ServiceWorkerVersionInfo(
23 ServiceWorkerVersion::RunningStatus running_status, 22 ServiceWorkerVersion::RunningStatus running_status,
24 ServiceWorkerVersion::Status status, 23 ServiceWorkerVersion::Status status,
25 const GURL& script_url, 24 const GURL& script_url,
26 int64 version_id, 25 int64 version_id,
27 int process_id, 26 int process_id,
28 int thread_id, 27 int thread_id,
29 int devtools_agent_route_id) 28 int devtools_agent_route_id)
30 : is_null(false), 29 : running_status(running_status),
31 running_status(running_status),
32 status(status), 30 status(status),
33 script_url(script_url), 31 script_url(script_url),
34 version_id(version_id), 32 version_id(version_id),
35 process_id(process_id), 33 process_id(process_id),
36 thread_id(thread_id), 34 thread_id(thread_id),
37 devtools_agent_route_id(devtools_agent_route_id) { 35 devtools_agent_route_id(devtools_agent_route_id) {
38 } 36 }
39 37
40 ServiceWorkerVersionInfo::~ServiceWorkerVersionInfo() {} 38 ServiceWorkerVersionInfo::~ServiceWorkerVersionInfo() {}
41 39
42 ServiceWorkerRegistrationInfo::ServiceWorkerRegistrationInfo() {} 40 ServiceWorkerRegistrationInfo::ServiceWorkerRegistrationInfo() {}
43 41
44 ServiceWorkerRegistrationInfo::ServiceWorkerRegistrationInfo( 42 ServiceWorkerRegistrationInfo::ServiceWorkerRegistrationInfo(
45 const GURL& pattern, 43 const GURL& pattern,
46 int64 registration_id, 44 int64 registration_id,
47 const ServiceWorkerVersionInfo& active_version, 45 const ServiceWorkerVersionInfo& active_version,
48 const ServiceWorkerVersionInfo& waiting_version, 46 const ServiceWorkerVersionInfo& waiting_version,
49 const ServiceWorkerVersionInfo& installing_version) 47 const ServiceWorkerVersionInfo& installing_version)
50 : pattern(pattern), 48 : pattern(pattern),
51 registration_id(registration_id), 49 registration_id(registration_id),
52 active_version(active_version), 50 active_version(active_version),
53 waiting_version(waiting_version), 51 waiting_version(waiting_version),
54 installing_version(installing_version) { 52 installing_version(installing_version) {
55 } 53 }
56 54
57 ServiceWorkerRegistrationInfo::~ServiceWorkerRegistrationInfo() {} 55 ServiceWorkerRegistrationInfo::~ServiceWorkerRegistrationInfo() {}
58 56
59 } // namespace content 57 } // namespace content
OLDNEW
« no previous file with comments | « content/browser/service_worker/service_worker_info.h ('k') | content/browser/service_worker/service_worker_internals_ui.cc » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698