content/browser/service_worker/service_worker_internals_ui.cc - Issue 691413002: Removing redundant 'is_null' field in ServiceWorkerVersionInfo

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: content/browser/service_worker/service_worker_internals_ui.cc

Issue 691413002: Removing redundant 'is_null' field in ServiceWorkerVersionInfo (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: Created 6 years, 2 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « content/browser/service_worker/service_worker_info.cc ('k') | content/browser/service_worker/service_worker_job_unittest.cc » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: content/browser/service_worker/service_worker_internals_ui.cc

diff --git a/content/browser/service_worker/service_worker_internals_ui.cc b/content/browser/service_worker/service_worker_internals_ui.cc

index 8265292445a47d508a2ba84cfaa6085f82cf6272..a7c8d71681356b90951808a176feef67971efce7 100644

--- a/content/browser/service_worker/service_worker_internals_ui.cc

+++ b/content/browser/service_worker/service_worker_internals_ui.cc

@@ -216,13 +216,15 @@ ListValue* GetRegistrationListValue(

registration_info->SetString(

"registration_id", base::Int64ToString(registration.registration_id));

- if (!registration.active_version.is_null) {

+ if (registration.active_version.version_id !=

+ kInvalidServiceWorkerVersionId) {

DictionaryValue* active_info = new DictionaryValue();

UpdateVersionInfo(registration.active_version, active_info);

registration_info->Set("active", active_info);

}

- if (!registration.waiting_version.is_null) {

+ if (registration.waiting_version.version_id !=

+ kInvalidServiceWorkerVersionId) {

DictionaryValue* waiting_info = new DictionaryValue();

UpdateVersionInfo(registration.waiting_version, waiting_info);

registration_info->Set("waiting", waiting_info);