Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(617)

Issue 691413002: Removing redundant 'is_null' field in ServiceWorkerVersionInfo (Closed)

Created:
6 years, 1 month ago by Paritosh Kumar
Modified:
6 years, 1 month ago
Reviewers:
michaeln, nhiroki, horo
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Project:
chromium
Visibility:
Public.

Description

Removing redundant 'is_null' field in ServiceWorkerVersionInfo Removing 'is_null' from ServiceWorkerVersionInfo in favor of comparing the version_id to kInvalidServiceWorker. BUG=428488 Committed: https://crrev.com/21637e9a68828694d7a7680aac5463abf63a8d85 Cr-Commit-Position: refs/heads/master@{#302243}

Patch Set 1 #

Total comments: 4

Patch Set 2 : #

Total comments: 1

Patch Set 3 : #

Patch Set 4 : #

Unified diffs Side-by-side diffs Delta from patch set Stats (+50 lines, -31 lines) Patch
M content/browser/service_worker/service_worker_browsertest.cc View 1 2 1 chunk +6 lines, -3 lines 0 comments Download
M content/browser/service_worker/service_worker_info.h View 1 chunk +0 lines, -1 line 0 comments Download
M content/browser/service_worker/service_worker_info.cc View 2 chunks +2 lines, -4 lines 0 comments Download
M content/browser/service_worker/service_worker_internals_ui.cc View 1 1 chunk +4 lines, -2 lines 0 comments Download
M content/browser/service_worker/service_worker_job_unittest.cc View 1 2 1 chunk +18 lines, -9 lines 0 comments Download
M content/browser/service_worker/service_worker_registration_unittest.cc View 1 2 3 4 chunks +20 lines, -10 lines 0 comments Download
M content/browser/service_worker/service_worker_storage.cc View 1 chunk +0 lines, -2 lines 0 comments Download

Messages

Total messages: 21 (8 generated)
Paritosh Kumar
PTAL.
6 years, 1 month ago (2014-10-31 05:14:16 UTC) #2
nhiroki
Drive-by comments. https://codereview.chromium.org/691413002/diff/1/content/browser/service_worker/service_worker_browsertest.cc File content/browser/service_worker/service_worker_browsertest.cc (right): https://codereview.chromium.org/691413002/diff/1/content/browser/service_worker/service_worker_browsertest.cc#newcode245 content/browser/service_worker/service_worker_browsertest.cc:245: if (infos[index].installing_version.version_id != kInvalidServiceWorkerVersionId) nit: You are ...
6 years, 1 month ago (2014-10-31 05:48:45 UTC) #4
Paritosh Kumar
Thanks Updated as suggested. PTAL. https://codereview.chromium.org/691413002/diff/1/content/browser/service_worker/service_worker_browsertest.cc File content/browser/service_worker/service_worker_browsertest.cc (right): https://codereview.chromium.org/691413002/diff/1/content/browser/service_worker/service_worker_browsertest.cc#newcode245 content/browser/service_worker/service_worker_browsertest.cc:245: if (infos[index].installing_version.version_id != kInvalidServiceWorkerVersionId) ...
6 years, 1 month ago (2014-10-31 06:53:19 UTC) #6
horo
https://codereview.chromium.org/691413002/diff/40001/content/browser/service_worker/service_worker_registration_unittest.cc File content/browser/service_worker/service_worker_registration_unittest.cc (right): https://codereview.chromium.org/691413002/diff/40001/content/browser/service_worker/service_worker_registration_unittest.cc#newcode124 content/browser/service_worker/service_worker_registration_unittest.cc:124: kInvalidServiceWorkerVersionId); +6 indent and others
6 years, 1 month ago (2014-10-31 07:09:10 UTC) #7
Paritosh Kumar
Thanks Updated. PTAL.
6 years, 1 month ago (2014-10-31 07:28:17 UTC) #8
horo
lgtm
6 years, 1 month ago (2014-10-31 07:32:08 UTC) #9
Paritosh Kumar
@nhiroki - Please any comments.
6 years, 1 month ago (2014-10-31 07:34:45 UTC) #11
nhiroki
LGTM, thank you for working on this!
6 years, 1 month ago (2014-10-31 07:45:13 UTC) #13
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/691413002/20002
6 years, 1 month ago (2014-10-31 07:47:27 UTC) #15
commit-bot: I haz the power
Try jobs failed on following builders: android_dbg_tests_recipe on tryserver.chromium.linux (http://build.chromium.org/p/tryserver.chromium.linux/builders/android_dbg_tests_recipe/builds/24071) linux_chromium_chromeos_rel on tryserver.chromium.linux (http://build.chromium.org/p/tryserver.chromium.linux/builders/linux_chromium_chromeos_rel/builds/7280)
6 years, 1 month ago (2014-10-31 08:01:48 UTC) #17
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/691413002/70001
6 years, 1 month ago (2014-10-31 08:08:33 UTC) #19
commit-bot: I haz the power
Committed patchset #4 (id:70001)
6 years, 1 month ago (2014-10-31 08:55:07 UTC) #20
commit-bot: I haz the power
6 years, 1 month ago (2014-10-31 08:55:40 UTC) #21
Message was sent while issue was closed.
Patchset 4 (id:??) landed as
https://crrev.com/21637e9a68828694d7a7680aac5463abf63a8d85
Cr-Commit-Position: refs/heads/master@{#302243}

Powered by Google App Engine
This is Rietveld 408576698