Removing redundant 'is_null' field in ServiceWorkerVersionInfo

Removing redundant 'is_null' field in ServiceWorkerVersionInfo

Removing 'is_null' from ServiceWorkerVersionInfo in favor of
comparing the version_id to kInvalidServiceWorker.

BUG=428488
Committed: https://crrev.com/21637e9a68828694d7a7680aac5463abf63a8d85
Cr-Commit-Position: refs/heads/master@{#302243}

[Paritosh Kumar, 2014-10-31 05:14:16]

paritosh.in@samsung.com changed reviewers:
+ horo@chromium.org, michaeln@chromium.org

[Paritosh Kumar, 2014-10-31 05:14:16]

PTAL.

[nhiroki, 2014-10-31 05:48:44]

nhiroki@chromium.org changed reviewers:
+ nhiroki@chromium.org

[nhiroki, 2014-10-31 05:48:45]

Drive-by comments.

https://codereview.chromium.org/691413002/diff/1/content/browser/service_work...
File content/browser/service_worker/service_worker_browsertest.cc (right):

https://codereview.chromium.org/691413002/diff/1/content/browser/service_work...
content/browser/service_worker/service_worker_browsertest.cc:245: if
(infos[index].installing_version.version_id != kInvalidServiceWorkerVersionId)
nit: You are not in Blink but in Chromium, so could you wrap this line and
others at 80 columns?

https://codereview.chromium.org/691413002/diff/1/content/browser/service_work...
File content/browser/service_worker/service_worker_job_unittest.cc (right):

https://codereview.chromium.org/691413002/diff/1/content/browser/service_work...
content/browser/service_worker/service_worker_job_unittest.cc:1071:
EXPECT_FALSE(entry.info.installing_version.version_id ==
kInvalidServiceWorkerVersionId);
You might want to use EXPECT_EQ/EXPECT_NE here and somewhere else.

EXPECT_EQ(kInvalidServiceWorkerVersionId,
entry.info.installing_version.version_id)

[Paritosh Kumar, 2014-10-31 06:50:11]

Patchset #2 (id:20001) has been deleted

[Paritosh Kumar, 2014-10-31 06:53:19]

Thanks

Updated as suggested. PTAL.

https://codereview.chromium.org/691413002/diff/1/content/browser/service_work...
File content/browser/service_worker/service_worker_browsertest.cc (right):

https://codereview.chromium.org/691413002/diff/1/content/browser/service_work...
content/browser/service_worker/service_worker_browsertest.cc:245: if
(infos[index].installing_version.version_id != kInvalidServiceWorkerVersionId)
On 2014/10/31 05:48:45, nhiroki wrote:
> nit: You are not in Blink but in Chromium, so could you wrap this line and
> others at 80 columns?

Done.

https://codereview.chromium.org/691413002/diff/1/content/browser/service_work...
File content/browser/service_worker/service_worker_job_unittest.cc (right):

https://codereview.chromium.org/691413002/diff/1/content/browser/service_work...
content/browser/service_worker/service_worker_job_unittest.cc:1071:
EXPECT_FALSE(entry.info.installing_version.version_id ==
kInvalidServiceWorkerVersionId);
On 2014/10/31 05:48:45, nhiroki wrote:
> You might want to use EXPECT_EQ/EXPECT_NE here and somewhere else.
> 
> EXPECT_EQ(kInvalidServiceWorkerVersionId,
> entry.info.installing_version.version_id)

Done.

[horo, 2014-10-31 07:09:10]

https://codereview.chromium.org/691413002/diff/40001/content/browser/service_...
File content/browser/service_worker/service_worker_registration_unittest.cc
(right):

https://codereview.chromium.org/691413002/diff/40001/content/browser/service_...
content/browser/service_worker/service_worker_registration_unittest.cc:124:
kInvalidServiceWorkerVersionId);
+6 indent

and others

[Paritosh Kumar, 2014-10-31 07:28:17]

Thanks

Updated. PTAL.

[horo, 2014-10-31 07:32:08]

lgtm

[Paritosh Kumar, 2014-10-31 07:34:45]

paritosh.in@samsung.com changed reviewers:
- horo@chromium.org

[Paritosh Kumar, 2014-10-31 07:34:45]

@nhiroki - Please any comments.

[Paritosh Kumar, 2014-10-31 07:39:31]

paritosh.in@samsung.com changed reviewers:
+ horo@chromium.org

[nhiroki, 2014-10-31 07:45:13]

LGTM, thank you for working on this!

[Paritosh Kumar, 2014-10-31 07:47:13]

The CQ bit was checked by paritosh.in@samsung.com

[commit-bot: I haz the power, 2014-10-31 07:47:27]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/691413002/20002

[commit-bot: I haz the power, 2014-10-31 08:01:48]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2014-10-31 08:01:48]

Try jobs failed on following builders:
  android_dbg_tests_recipe on tryserver.chromium.linux
(http://build.chromium.org/p/tryserver.chromium.linux/builders/android_dbg_tes...)
  linux_chromium_chromeos_rel on tryserver.chromium.linux
(http://build.chromium.org/p/tryserver.chromium.linux/builders/linux_chromium_...)

[Paritosh Kumar, 2014-10-31 08:07:50]

The CQ bit was checked by paritosh.in@samsung.com

[commit-bot: I haz the power, 2014-10-31 08:08:33]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/691413002/70001

[commit-bot: I haz the power, 2014-10-31 08:55:07]

Committed patchset #4 (id:70001)

[commit-bot: I haz the power, 2014-10-31 08:55:40]

Patchset 4 (id:??) landed as
https://crrev.com/21637e9a68828694d7a7680aac5463abf63a8d85
Cr-Commit-Position: refs/heads/master@{#302243}