ppapi/proxy/tcp_socket_resource_base.h - Issue 690903002: Remove timing limitation of SetOption invocation for PPAPI sockets.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: ppapi/proxy/tcp_socket_resource_base.h

Issue 690903002: Remove timing limitation of SetOption invocation for PPAPI sockets. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: Rebase and fixed implementation. Created 6 years ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

Index: ppapi/proxy/tcp_socket_resource_base.h

diff --git a/ppapi/proxy/tcp_socket_resource_base.h b/ppapi/proxy/tcp_socket_resource_base.h

index 8835ab974b16dae180946e3cb76d7850ea901e3c..3274fb9518e91e8f6bee72a65653ce17fa7a9b74 100644

--- a/ppapi/proxy/tcp_socket_resource_base.h

+++ b/ppapi/proxy/tcp_socket_resource_base.h

@@ -95,6 +95,7 @@ class PPAPI_PROXY_EXPORT TCPSocketResourceBase : public PluginResource {

void CloseImpl();

int32_t SetOptionImpl(PP_TCPSocket_Option name,

const PP_Var& value,

+ bool check_connect_state,

scoped_refptr<TrackedCallback> callback);

void PostAbortIfNecessary(scoped_refptr<TrackedCallback>* callback);

« ppapi/api/ppb_udp_socket.idl ('K') | « ppapi/proxy/tcp_socket_resource.cc ('k') | ppapi/proxy/tcp_socket_resource_base.cc » ('j') | ppapi/proxy/udp_socket_resource_base.h » ('J')