Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(199)

Unified Diff: ppapi/proxy/udp_socket_resource_base.h

Issue 690903002: Remove timing limitation of SetOption invocation for PPAPI sockets. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Rebase and fixed implementation. Created 6 years ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: ppapi/proxy/udp_socket_resource_base.h
diff --git a/ppapi/proxy/udp_socket_resource_base.h b/ppapi/proxy/udp_socket_resource_base.h
index 5400f6be99554d3dec8f57d430d1912954fd8c54..c6eef8ba43e8199724906c5cb5038586d555bb44 100644
--- a/ppapi/proxy/udp_socket_resource_base.h
+++ b/ppapi/proxy/udp_socket_resource_base.h
@@ -54,6 +54,7 @@ class PPAPI_PROXY_EXPORT UDPSocketResourceBase: public PluginResource {
int32_t SetOptionImpl(PP_UDPSocket_Option name,
const PP_Var& value,
+ bool check_bind_state,
scoped_refptr<TrackedCallback> callback);
int32_t BindImpl(const PP_NetAddress_Private* addr,
scoped_refptr<TrackedCallback> callback);
@@ -106,6 +107,11 @@ class PPAPI_PROXY_EXPORT UDPSocketResourceBase: public PluginResource {
PP_Resource* output_addr);
bool private_api_;
+
+ // |bind_called_| is true if Bind() is called, while |bound_| is true,
bbudge 2014/12/09 18:37:38 nit: s/if /after I think the comment would be slig
hidehiko 2014/12/09 19:51:42 Done.
+ // after Bind() succeeds. Bind() is an asynchronous method, so the timing
+ // on which of these is set is slightly different.
+ bool bind_called_;
bool bound_;
bool closed_;

Powered by Google App Engine
This is Rietveld 408576698